Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: chrome/browser/download/save_package.cc

Issue 6096003: Put history insertion for downloads processing inline. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments, fixed windows int64->int compile error. Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/download/save_package.h" 5 #include "chrome/browser/download/save_package.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "app/l10n_util.h" 9 #include "app/l10n_util.h"
10 #include "base/file_path.h" 10 #include "base/file_path.h"
(...skipping 668 matching lines...) Expand 10 before | Expand all | Expand 10 after
679 for (SaveUrlItemMap::iterator it = saved_failed_items_.begin(); 679 for (SaveUrlItemMap::iterator it = saved_failed_items_.begin();
680 it != saved_failed_items_.end(); ++it) 680 it != saved_failed_items_.end(); ++it)
681 save_ids.push_back(it->second->save_id()); 681 save_ids.push_back(it->second->save_id());
682 682
683 BrowserThread::PostTask( 683 BrowserThread::PostTask(
684 BrowserThread::FILE, FROM_HERE, 684 BrowserThread::FILE, FROM_HERE,
685 NewRunnableMethod(file_manager_, 685 NewRunnableMethod(file_manager_,
686 &SaveFileManager::RemoveSavedFileFromFileMap, 686 &SaveFileManager::RemoveSavedFileFromFileMap,
687 save_ids)); 687 save_ids));
688 688
689 download_->OnAllDataSaved(all_save_items_count_); 689 download_->OnReadyToFinish(all_save_items_count_);
690 // Notify download observers that we are complete (the call 690 // Notify download observers that we are complete (the call
691 // to OnAllDataSaved() set the state to complete but did not notify). 691 // to OnReadyToFinish() set the state to complete but did not notify).
692 download_->UpdateObservers(); 692 download_->UpdateObservers();
693 693
694 NotificationService::current()->Notify( 694 NotificationService::current()->Notify(
695 NotificationType::SAVE_PACKAGE_SUCCESSFULLY_FINISHED, 695 NotificationType::SAVE_PACKAGE_SUCCESSFULLY_FINISHED,
696 Source<SavePackage>(this), 696 Source<SavePackage>(this),
697 Details<GURL>(&page_url_)); 697 Details<GURL>(&page_url_));
698 } 698 }
699 699
700 // Called for updating end state. 700 // Called for updating end state.
701 void SavePackage::SaveFinished(int32 save_id, int64 size, bool is_success) { 701 void SavePackage::SaveFinished(int32 save_id, int64 size, bool is_success) {
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1369 } 1369 }
1370 1370
1371 // SelectFileDialog::Listener interface. 1371 // SelectFileDialog::Listener interface.
1372 void SavePackage::FileSelected(const FilePath& path, 1372 void SavePackage::FileSelected(const FilePath& path,
1373 int index, void* params) { 1373 int index, void* params) {
1374 ContinueSave(path, index); 1374 ContinueSave(path, index);
1375 } 1375 }
1376 1376
1377 void SavePackage::FileSelectionCanceled(void* params) { 1377 void SavePackage::FileSelectionCanceled(void* params) {
1378 } 1378 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698