Put history insertion for downloads processing inline.

chrome/browser/download/download_manager.h

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // The DownloadManager object manages the process of downloading, including
 // updates to the history system and providing the information for displaying
 // the downloads view in the Destinations tab. There is one DownloadManager per
 // active profile in Chrome.
 //
 // Download observers:
@@ skipping 107 matching lines @@
   // Notifications sent from the download thread to the UI thread
   void StartDownload(DownloadCreateInfo* info);
   void UpdateDownload(int32 download_id, int64 size);
   void OnAllDataSaved(int32 download_id, int64 size);
 
   // Called from a view when a user clicks a UI button or link.
   void DownloadCancelled(int32 download_id);
   void PauseDownload(int32 download_id, bool pause);
   void RemoveDownload(int64 download_handle);
 
+  // Complete the non-racing portion of the download after
+  // all UI initialization had occurred and all data has
+  // arrived.  Called from locations where it is possible
+  // those conditions may apply.
+  void MaybeCompleteDownload(int32 download_id, int64 size);

[Paweł Hajdan Jr., 2011/01/03 09:43:03]

Can we find a more descriptive name, i.e. one that describes what this method
does, not when it is called?

[Randy Smith (Not in Mondays), 2011/01/04 19:29:21]

Hmmm.  My call would be that MaybeCompleteDownload actually does describe what
the call does.  Based on a certain set of conditions it may or may not complete
the download.  But I think your concern applies well to the comment, and I've
tried to update the comment to reflect that concern.  Let me know what you
think.

+
   // Called when the download is renamed to its final name.
   void DownloadRenamedToFinalName(int download_id, const FilePath& full_path);
 
   // Remove downloads after remove_begin (inclusive) and before remove_end
   // (exclusive). You may pass in null Time values to do an unbounded delete
   // in either direction.
   int RemoveDownloadsBetween(const base::Time remove_begin,
                              const base::Time remove_end);
 
   // Remove downloads will delete all downloads that have a timestamp that is
@@ skipping 233 matching lines @@
   // The "Save As" dialog box used to ask the user where a file should be
   // saved.
   scoped_refptr<SelectFileDialog> select_file_dialog_;
 
   scoped_ptr<OtherDownloadManagerObserver> other_download_manager_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadManager);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_MANAGER_H_