Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 6094020: Simplify CheckPrototypeMaps. (Closed)

Created:
9 years, 11 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Simplify CheckPrototypeMaps. This instruction only depends on the prototype and the holder and can completely ignore the receiver and its map. This change also fixes a small bug on arm where a cell was loaded instead of the prototype from new space. Committed: http://code.google.com/p/v8/source/detail?r=6290

Patch Set 1 #

Patch Set 2 : Update ARM lithium #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -28 lines) Patch
M src/arm/lithium-arm.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/hydrogen-instructions.h View 3 chunks +15 lines, -17 lines 1 comment Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 11 months ago (2011-01-12 19:54:56 UTC) #1
fschneider
9 years, 11 months ago (2011-01-12 22:45:01 UTC) #2
LGTM!

http://codereview.chromium.org/6094020/diff/3001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

http://codereview.chromium.org/6094020/diff/3001/src/hydrogen-instructions.h#...
src/hydrogen-instructions.h:1643: ASSERT(!Heap::allow_allocation(false));
I think
 
ASSERT(!Heap::IsAllocationAllowed());

would be read a little better here and assert the same property.

Powered by Google App Engine
This is Rietveld 408576698