Issue 6094010: Add support for user actions to the metrics library and the metrics clients.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6094010: Add support for user actions to the metrics library and the metrics clients. (Closed)

Created:
9 years, 11 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato, Daniel Erat

CC:
chromium-os-reviews_chromium.org, petkov, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/metrics.git@master

Visibility:
Public.

Description

Add support for user actions to the metrics library and the metrics clients. BUG=10696 TEST=unit tests, tested on the device through metrics_client and inspecting the uma-events file. Change-Id: Ie39dd8b5ab968c328993076369a4ba14cb7fcd81 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=436f32a

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -22 lines)			Patch
M	README	View	2 chunks	+6 lines, -16 lines	0 comments	Download
M	c_metrics_library.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	c_metrics_library.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	metrics_client.cc	View	7 chunks	+23 lines, -5 lines	0 comments	Download
M	metrics_library.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	metrics_library.cc	View	2 chunks	+12 lines, -1 line	0 comments	Download
M	metrics_library_test.cc	View	2 chunks	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

9 years, 11 months ago (2011-01-06 18:45:17 UTC) #3

LGTM 2

On 2011/01/06 18:40:07, Daniel Erat wrote:
> LGTM
> 
> Thanks for adding this so quickly!

Expand Messages | Collapse Messages