Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 6094003: Suppress UserScript/Pango race report (false positive?), remove some suppress... (Closed)

Created:
10 years ago by Timur Iskhodzhanov
Modified:
9 years, 6 months ago
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Suppress UserScript/Pango race report (false positive?), remove some suppressions for probably-fixed bugs. BUG=67957, 64080, 64186, 64188, 67546 TBR=glider TEST=TSan/UI bots should remain green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70148

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -44 lines) Patch
M tools/valgrind/tsan/suppressions.txt View 2 chunks +5 lines, -44 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Timur Iskhodzhanov
10 years ago (2010-12-24 10:21:46 UTC) #1
Alexander Potapenko
10 years ago (2010-12-24 10:43:03 UTC) #2
LGTM

On Fri, Dec 24, 2010 at 1:21 PM,  <timurrrr@chromium.org> wrote:
> Reviewers: Alexander Potapenko,
>
> Description:
> Suppress UserScript/Pango race report (false positive?), remove some
> suppressions for probably-fixed bugs.
> BUG=67957,64080,64186,64188,67546
> TBR=glider
> TEST=TSan/UI bots should remain green
>
> Please review this at http://codereview.chromium.org/6094003/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src/
>
> Affected files:
>  M     tools/valgrind/tsan/suppressions.txt
>
>
> Index: tools/valgrind/tsan/suppressions.txt
> ===================================================================
> --- tools/valgrind/tsan/suppressions.txt        (revision 70146)
> +++ tools/valgrind/tsan/suppressions.txt        (working copy)
> @@ -80,36 +80,6 @@
>  }
>
>  {
> -  bug_64080
> -  ThreadSanitizer:Race
> -  ...
> -  fun:chromeos::PulseAudioMixer::~PulseAudioMixer*
> -  ...
> -  fun:Singleton<chromeos::AudioHandler*>::OnExit*
> -}
> -
> -{
> -  bug_64186a
> -  ThreadSanitizer:Race
> -  fun:chromeos::CrosLibrary::Library*GetDefaultImpl*
> -  fun:chromeos::CrosLibrary::GetSystemLibrary*
> -}
> -
> -{
> -  bug_64186b
> -  ThreadSanitizer:Race
> -  ...
> -  fun:MetricsService::InitTask::Run*
> -}
> -
> -{
> -  bug_64188
> -  ThreadSanitizer:Race
> -  ...
> -  fun:base::RefCounted<net::NetLog::EventParameters>::*
> -}
> -
> -{
>   bug_66994a
>   ThreadSanitizer:Race
>   fun:HistoryURLProvider::Stop*
> @@ -124,23 +94,14 @@
>  }
>
>  {
> -  bug_67546a
> +  bug_67957
>   ThreadSanitizer:Race
> -  ...
> -  fun:g_main_context_dispatch
> -  fun:g_main_context_iterate
> -  fun:g_main_context_iteration
> +  fun:Replace_memcpy
> +  fun:memcpy
> +  fun:Serialize*
> +  fun:UserScriptMaster::ScriptReloader::RunScan*
>  }
>
> -{
> -  bug_67546b
> -  ThreadSanitizer:Race
> -  ...
> -  fun:g_cclosure_marshal_VOID__OBJECT
> -  fun:g_type_class_meta_marshal
> -  fun:g_closure_invoke
> -}
> -
>  ############################
>  # Benign races
>  {
>
>
>

Powered by Google App Engine
This is Rietveld 408576698