Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Side by Side Diff: chrome/test/automation/tab_proxy.h

Issue 6094002: Revert 70141 - Make a few more places use bool for OnMessageReceived.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/common/ipc_test_sink.cc ('k') | chrome_frame/chrome_frame_automation.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_AUTOMATION_TAB_PROXY_H_ 5 #ifndef CHROME_TEST_AUTOMATION_TAB_PROXY_H_
6 #define CHROME_TEST_AUTOMATION_TAB_PROXY_H_ 6 #define CHROME_TEST_AUTOMATION_TAB_PROXY_H_
7 #pragma once 7 #pragma once
8 8
9 #include "build/build_config.h" // NOLINT 9 #include "build/build_config.h" // NOLINT
10 10
(...skipping 30 matching lines...) Expand all
41 MEDIUM_FONT = 16, 41 MEDIUM_FONT = 16,
42 LARGE_FONT = 24, 42 LARGE_FONT = 24,
43 LARGEST_FONT = 36 43 LARGEST_FONT = 36
44 }; 44 };
45 45
46 class TabProxy : public AutomationResourceProxy, 46 class TabProxy : public AutomationResourceProxy,
47 public JavaScriptExecutionController { 47 public JavaScriptExecutionController {
48 public: 48 public:
49 class TabProxyDelegate { 49 class TabProxyDelegate {
50 public: 50 public:
51 virtual bool OnMessageReceived(TabProxy* tab, const IPC::Message& msg) {} 51 virtual void OnMessageReceived(TabProxy* tab, const IPC::Message& msg) {}
52 virtual void OnChannelError(TabProxy* tab) {} 52 virtual void OnChannelError(TabProxy* tab) {}
53 53
54 protected: 54 protected:
55 virtual ~TabProxyDelegate() {} 55 virtual ~TabProxyDelegate() {}
56 }; 56 };
57 57
58 TabProxy(AutomationMessageSender* sender, 58 TabProxy(AutomationMessageSender* sender,
59 AutomationHandleTracker* tracker, 59 AutomationHandleTracker* tracker,
60 int handle); 60 int handle);
61 61
(...skipping 361 matching lines...) Expand 10 before | Expand all | Expand 10 after
423 // purposes. 423 // purposes.
424 void LastObjectRemoved(); 424 void LastObjectRemoved();
425 425
426 private: 426 private:
427 Lock list_lock_; // Protects the observers_list_. 427 Lock list_lock_; // Protects the observers_list_.
428 ObserverList<TabProxyDelegate> observers_list_; 428 ObserverList<TabProxyDelegate> observers_list_;
429 DISALLOW_COPY_AND_ASSIGN(TabProxy); 429 DISALLOW_COPY_AND_ASSIGN(TabProxy);
430 }; 430 };
431 431
432 #endif // CHROME_TEST_AUTOMATION_TAB_PROXY_H_ 432 #endif // CHROME_TEST_AUTOMATION_TAB_PROXY_H_
OLDNEW
« no previous file with comments | « chrome/common/ipc_test_sink.cc ('k') | chrome_frame/chrome_frame_automation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698