Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 6094001: Update parallel_emerge to experimentally support Portage 2.1.9. (Closed)

Created:
10 years ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Update parallel_emerge to experimentally support Portage 2.1.9. Portage 2.1.9 changes a few APIs, so parallel_emerge needs to change with it. With this patch, parallel_emerge basically seems to work with Portage 2.1.9. Note #1: All of our patches against Portage 2.1.7 will need to be forward ported to Portage 2.1.9 before we'll have complete support for it. See http://codereview.chromium.org/6093002/ for that. Note #2: This includes http://codereview.chromium.org/6055004/ . That patch can be submitted separately, though, and that'll make this patch smaller. BUG=chromium-os:10574 TEST=Ran ./build_packages --board=x86-generic --oldchromebinary with and without new portage. It completes successfully in both cases. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8ce81f3

Patch Set 1 : Re-upload. #

Patch Set 2 : Protecting output.fileno() wasn't enough -- protect all file descriptors #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -20 lines) Patch
M parallel_emerge View 1 2 9 chunks +36 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
davidjames
10 years ago (2010-12-23 19:14:42 UTC) #1
Nick Sanders
9 years, 11 months ago (2011-01-04 23:11:54 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698