Some RTL fixes for tabbed options.

Some RTL fixes for tabbed options.

- get the padding right for favicons in lists
- fix action areas
- margin => -webkit-margin

BUG=67849
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70234

[James Hawkins, 2010-12-23 00:40:45]

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/content_settings.css (right):

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/content_settings.css:51: .otrExplanation {
nit: Class style is the same as ID style = class-name

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:80: bottom: 0px;
nit: Take off the 'px' for 0.

[Evan Stade, 2010-12-23 00:48:21]

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/content_settings.css (right):

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/content_settings.css:51: .otrExplanation {
On 2010/12/23 00:40:45, James Hawkins wrote:
> nit: Class style is the same as ID style = class-name

arv suggested this change:
http://codereview.chromium.org/6059006/diff/1/chrome/browser/resources/option...

granted, there doesn't seem to be much consistency in this regard.

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6093001/diff/2001/chrome/browser/resources/opt...
chrome/browser/resources/options/options_page.css:80: bottom: 0px;
On 2010/12/23 00:40:45, James Hawkins wrote:
> nit: Take off the 'px' for 0.

Done.

[Evan Stade, 2010-12-23 01:48:13]

ok, fixed a bunch of classes and IDs to the hyphen style

[James Hawkins, 2010-12-23 01:53:28]

http://codereview.chromium.org/6093001/diff/14001/chrome/browser/dom_ui/optio...
File chrome/browser/dom_ui/options/content_settings_handler.cc (right):

http://codereview.chromium.org/6093001/diff/14001/chrome/browser/dom_ui/optio...
chrome/browser/dom_ui/options/content_settings_handler.cc:181:
localized_strings->SetString("content_settings_page",
nit: Sorry I missed this before. This isn't in a style guide, but we've agreed
upon a style for JS strings to match JS function-naming style: camelCase.

http://codereview.chromium.org/6093001/diff/14001/chrome/browser/resources/op...
File chrome/browser/resources/options/content_settings_exceptions_area.html
(right):

http://codereview.chromium.org/6093001/diff/14001/chrome/browser/resources/op...
chrome/browser/resources/options/content_settings_exceptions_area.html:1: <div
class="page hidden" id="content-settings-exceptions-area">
nit: id should be the first attribute.

[Evan Stade, 2010-12-23 02:07:17]

done and done

[James Hawkins, 2010-12-23 02:08:58]

LGTM, thanks.

[arv (Not doing code reviews), 2010-12-23 17:55:39]

LGTM

http://codereview.chromium.org/6093001/diff/20001/chrome/browser/resources/op...
File chrome/browser/resources/options/options_page.css (right):

http://codereview.chromium.org/6093001/diff/20001/chrome/browser/resources/op...
chrome/browser/resources/options/options_page.css:88: left: 0px;
left: 0;