Issue 6091010: Merge 70318 - [Chrome OS] Respect periods in google apps account names...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6091010: Merge 70318 - [Chrome OS] Respect periods in google apps account names... (Closed)

Created:
9 years, 11 months ago by oritm

Modified:
9 years, 4 months ago

Reviewers:
Chris Masone

CC:
chromium-reviews, Paweł Hajdan Jr., nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/597/src/

Visibility:
Public.

Merge 70318 - [Chrome OS] Respect periods in google apps account names When logging in to @gmail.com accounts via the web, . characters are ignored -- which we do on chrome OS. When logging into google apps accounts for OTHER domains, . characters should NOT be ignored. We were canonicalizing them out on Chrome OS, breaking login for apps users who have . embedded in their usernames. BUG=chromium-os:10397 TEST=unit tests, install on device and try cmasone@gmail.com, c.masone@gmail.com, why.you@mydomain.org and whyyou@mydomain.org. The first three work, the last one does not, as expected. Review URL: http://codereview.chromium.org/6089004 TBR=cmasone@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70398

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -7 lines)			Patch
M	chrome/browser/chromeos/login/authenticator.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/authenticator.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/authenticator_unittest.cc	View	1 chunk	+16 lines, -6 lines	0 comments	Download

Total messages: 1 (0 generated)