Issue 6091007: Tweak atomicops implementation for Mac OS X to compile correctly when __LP64_...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6091007: Tweak atomicops implementation for Mac OS X to compile correctly when __LP64_... (Closed)

Created:
9 years, 12 months ago by eschew

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Tweak atomicops implementation for Mac OS X to compile correctly when __LP64__ is defined. Patch by Ben Karel <eschew@gmail.com>;. BUG=54554 TEST= - base_unittests --gtest_filter='AtomicOpsTest.*' - Compile base/string_util.cc (outside of Chromium) as 64-bit code on Mac OS X 10.6. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70942

Patch Set 1 #

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -10 lines)			Patch
	M	AUTHORS	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	base/atomicops_internals_x86_macosx.h	View		5 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Thanks for the patch. Have you signed the Contributor License Agreement?

9 years, 11 months ago (2011-01-10 18:50:49 UTC) #1

eschew

On 2011/01/10 18:50:49, Mark Mentovai wrote: > Thanks for the patch. Have you signed the ...

9 years, 11 months ago (2011-01-10 20:49:14 UTC) #2

Mark Mentovai

9 years, 11 months ago (2011-01-10 21:11:00 UTC) #3

LGTM. I’m doing a bit of testing, and then I’ll commit this.

FYI, this file is so cast-happy because it needed to work with the 10.4u SDK
when it was initially written, and none of the declarations in that SDK version
have “volatile” qualifiers. Since we only care about the 10.5 SDK now (and the
10.6 SDK for future compatibility), we can likely drop many of the casts in this
file. I would review a change to do that if you found yourself motivated.

Expand Messages | Collapse Messages