chrome_frame/utils.cc - Issue 6091006: Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome_frame/utils.cc

Issue 6091006: Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 2. (Closed)

Patch Set: Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome_frame/utils.cc

diff --git a/chrome_frame/utils.cc b/chrome_frame/utils.cc

index 565990b165877200c54c62a6ba158d69b853eefe..11e6fd880be553ed030ed71344fb4f0ef9ce941b 100644

--- a/chrome_frame/utils.cc

+++ b/chrome_frame/utils.cc

@@ -415,7 +415,7 @@ uint32 GetIEMajorVersion() {

wchar_t exe_path[MAX_PATH];

HMODULE mod = GetModuleHandle(NULL);

GetModuleFileName(mod, exe_path, arraysize(exe_path) - 1);

- std::wstring exe_name(file_util::GetFilenameFromPath(exe_path));

+ std::wstring exe_name = FilePath(exe_path).BaseName().ToWStringHack();

evanm 2010/12/23 18:13:33 Since this is Windows-specific code, could you use

tfarina 2010/12/23 18:27:00 Done.

if (!LowerCaseEqualsASCII(exe_name, kIEImageName)) {

ie_major_version = 0;

} else {

« no previous file with comments | « no previous file | no next file » | no next file with comments »