Issue 6091006: Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6091006: Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 2. (Closed)

Created:
10 years ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, evanm

CC:
chromium-reviews, amit

Visibility:
Public.

Description

Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 2. BUG=24672 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70128

Patch Set 2 : value #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome_frame/utils.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

evanm

LGTM http://codereview.chromium.org/6091006/diff/1/chrome_frame/utils.cc File chrome_frame/utils.cc (right): http://codereview.chromium.org/6091006/diff/1/chrome_frame/utils.cc#newcode418 chrome_frame/utils.cc:418: std::wstring exe_name = FilePath(exe_path).BaseName().ToWStringHack(); Since this is Windows-specific ...

10 years ago (2010-12-23 18:13:33 UTC) #2

tfarina

10 years ago (2010-12-23 18:27:00 UTC) #3

http://codereview.chromium.org/6091006/diff/1/chrome_frame/utils.cc
File chrome_frame/utils.cc (right):

http://codereview.chromium.org/6091006/diff/1/chrome_frame/utils.cc#newcode418
chrome_frame/utils.cc:418: std::wstring exe_name =
FilePath(exe_path).BaseName().ToWStringHack();
On 2010/12/23 18:13:33, evanm wrote:
> Since this is Windows-specific code, could you use .value() instead of
> .ToWStringHack()?

Done.

Expand Messages | Collapse Messages

Issue 6091006: Use FilePath::BaseName instead of the deprecated file_util::GetFilenameFromPath. Part 2. (Closed)

Description

Patch Set 1 #

Patch Set 2 : value #

Messages