Refactor the windows policy provider to use AsynchronousPolicyProvider.

chrome/browser/policy/asynchronous_policy_provider_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/asynchronous_policy_loader.h"
 #include "chrome/browser/policy/asynchronous_policy_provider.h"
 #include "chrome/browser/policy/asynchronous_policy_test_base.h"
 #include "chrome/browser/policy/configuration_policy_pref_store.h"
 #include "chrome/browser/policy/mock_configuration_policy_store.h"
 #include "chrome/common/policy_constants.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::InSequence;
 using ::testing::Return;
 
 namespace policy {
 
+// Creating the provider should provide initial policy.
 TEST_F(AsynchronousPolicyTestBase, Provide) {
   InSequence s;
   DictionaryValue* policies = new DictionaryValue();
   policies->SetBoolean(policy::key::kSyncDisabled, true);
   EXPECT_CALL(*delegate_, Load()).WillOnce(Return(policies));
   EXPECT_CALL(*store_, Apply(policy::kPolicySyncDisabled, _)).Times(1);
   AsynchronousPolicyProvider provider(
       ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
-      new AsynchronousPolicyLoader(delegate_.release()));
+      new AsynchronousPolicyLoader(delegate_.release(), 10));
   provider.Provide(store_.get());
 }
 
+
+// Trigger a refresh manually and ensure that policy gets reloaded.
 TEST_F(AsynchronousPolicyTestBase, ProvideAfterRefresh) {
   InSequence s;
   DictionaryValue* original_policies = new DictionaryValue();
   original_policies->SetBoolean(policy::key::kSyncDisabled, true);
   EXPECT_CALL(*delegate_, Load()).WillOnce(Return(original_policies));
   DictionaryValue* refresh_policies = new DictionaryValue();
   refresh_policies->SetBoolean(
       policy::key::kJavascriptEnabled,
       true);
   EXPECT_CALL(*delegate_, Load()).WillOnce(Return(refresh_policies));
   AsynchronousPolicyLoader* loader = new AsynchronousPolicyLoader(
-      delegate_.release());
+      delegate_.release(),
+      10);

[Mattias Nissler (ping if slow), 2010/12/21 16:42:24]

Linebreak after = and all arguments on the same line?

[danno, 2010/12/22 11:02:17]

Done.

   AsynchronousPolicyProvider provider(
       ConfigurationPolicyPrefStore::GetChromePolicyDefinitionList(),
       loader);
   loop_.RunAllPending();
   loader->Reload();
   loop_.RunAllPending();
   EXPECT_CALL(*store_, Apply(policy::kPolicyJavascriptEnabled, _)).Times(1);
   provider.Provide(store_.get());
 }
 
 }  // namespace policy