Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5576)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/util/delete_after_reboot_helper.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/installer/util/create_reg_key_work_item_unittest.cc ('k') | chrome/installer/util/delete_reg_value_work_item.cc » ('j') | chrome_frame/chrome_tab.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/delete_after_reboot_helper.cc
===================================================================
--- chrome/installer/util/delete_after_reboot_helper.cc (revision 70917)
+++ chrome/installer/util/delete_after_reboot_helper.cc (working copy)
@@ -379,7 +379,8 @@
if (strings_to_keep.size() <= 1) {
// We have only the trailing NULL string. Don't bother writing that.
- return session_manager_key.DeleteValue(kPendingFileRenameOps);
+ LONG result = session_manager_key.DeleteValue(kPendingFileRenameOps);
+ return result == ERROR_SUCCESS;
}
std::vector<char> buffer;
StringArrayToMultiSZBytes(strings_to_keep, &buffer);
@@ -387,5 +388,5 @@
if (buffer.empty())
return false;
return session_manager_key.WriteValue(kPendingFileRenameOps, &buffer[0],
- buffer.size(), REG_MULTI_SZ);
+ buffer.size(), REG_MULTI_SZ) == ERROR_SUCCESS;
}
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/installer/util/create_reg_key_work_item_unittest.cc ('k') | chrome/installer/util/delete_reg_value_work_item.cc » ('j') | chrome_frame/chrome_tab.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698