Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1040)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/shell_dialogs_win.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/browser/ui/views/external_protocol_dialog.cc ('k') | chrome/common/chrome_plugin_lib.cc » ('j') | chrome_frame/chrome_tab.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/shell_dialogs_win.cc
===================================================================
--- chrome/browser/ui/views/shell_dialogs_win.cc (revision 70917)
+++ chrome/browser/ui/views/shell_dialogs_win.cc (working copy)
@@ -75,9 +75,9 @@
DCHECK(reg_description);
base::win::RegKey reg_ext(HKEY_CLASSES_ROOT, file_ext.c_str(), KEY_READ);
std::wstring reg_app;
- if (reg_ext.ReadValue(NULL, &reg_app) && !reg_app.empty()) {
+ if (reg_ext.ReadValue(NULL, &reg_app) == ERROR_SUCCESS && !reg_app.empty()) {
base::win::RegKey reg_link(HKEY_CLASSES_ROOT, reg_app.c_str(), KEY_READ);
- if (reg_link.ReadValue(NULL, reg_description))
+ if (reg_link.ReadValue(NULL, reg_description) == ERROR_SUCCESS)
return true;
}
return false;
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/browser/ui/views/external_protocol_dialog.cc ('k') | chrome/common/chrome_plugin_lib.cc » ('j') | chrome_frame/chrome_tab.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698