Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1410)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ceee/ie/plugin/toolband/toolband_proxy.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ceee/ie/common/ceee_util.cc ('K') | « ceee/ie/common/ie_util_unittest.cc ('k') | ceee/installer_dll/installer_helper.cc » ('j') | ceee/installer_dll/installer_helper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ceee/ie/plugin/toolband/toolband_proxy.cc
===================================================================
--- ceee/ie/plugin/toolband/toolband_proxy.cc (revision 71561)
+++ ceee/ie/plugin/toolband/toolband_proxy.cc (working copy)
@@ -51,11 +51,12 @@
L"Interface\\%ls\\AsynchronousInterface", iid_str.c_str());
base::win::RegKey key;
- if (key.Open(HKEY_CLASSES_ROOT, key_name.c_str(), KEY_READ)) {
+ if (key.Open(HKEY_CLASSES_ROOT, key_name.c_str(), KEY_READ)
+ == ERROR_SUCCESS) {
grt (UTC plus 2) 2011/01/16 04:19:48 Wrapping
amit 2011/01/16 07:54:28 Done.
// It's registered, the rest of this block is debug checking that
// the correct IID is indeed registered for the async interface.
std::wstring async_iid_str;
- DCHECK(key.ReadValue(NULL, &async_iid_str));
+ DCHECK_EQ(ERROR_SUCCESS, key.ReadValue(NULL, &async_iid_str));
IID read_async_iid;
DCHECK(SUCCEEDED(::IIDFromString(async_iid_str.c_str(), &read_async_iid)));
DCHECK(read_async_iid == async_iid);
« ceee/ie/common/ceee_util.cc ('K') | « ceee/ie/common/ie_util_unittest.cc ('k') | ceee/installer_dll/installer_helper.cc » ('j') | ceee/installer_dll/installer_helper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698