Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3881)

Unified Diff: chrome/installer/util/set_reg_value_work_item.h

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/product_unittest.cc ('k') | chrome/installer/util/set_reg_value_work_item.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/set_reg_value_work_item.h
===================================================================
--- chrome/installer/util/set_reg_value_work_item.h (revision 71761)
+++ chrome/installer/util/set_reg_value_work_item.h (working copy)
@@ -9,6 +9,7 @@
#include <windows.h>
#include <string>
+#include <vector>
#include "chrome/installer/util/work_item.h"
@@ -66,23 +67,16 @@
// Name of the value to be set.
std::wstring value_name_;
- // Data of the value to be set.
- std::wstring value_data_str_; // if data is of type REG_SZ
- DWORD value_data_dword_; // if data is of type REG_DWORD
- int64 value_data_qword_; // if data is of type REG_QWORD
-
// Whether to overwrite the existing value under the target key.
bool overwrite_;
// Type of data to store
DWORD type_;
+ std::vector<uint8> value_;
+ DWORD previous_type_;
+ std::vector<uint8> previous_value_;
SettingStatus status_;
-
- // Data of the previous value.
- std::wstring previous_value_str_; // if data is of type REG_SZ
- DWORD previous_value_dword_; // if data is of type REG_DWORD
- int64 previous_value_qword_; // if data is of type REG_QWORD
};
#endif // CHROME_INSTALLER_UTIL_SET_REG_VALUE_WORK_ITEM_H__
« no previous file with comments | « chrome/installer/util/product_unittest.cc ('k') | chrome/installer/util/set_reg_value_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698