Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2368)

Unified Diff: chrome/installer/util/install_util_unittest.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/util/install_util.cc ('k') | chrome/installer/util/installation_state.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/install_util_unittest.cc
===================================================================
--- chrome/installer/util/install_util_unittest.cc (revision 71761)
+++ chrome/installer/util/install_util_unittest.cc (working copy)
@@ -45,9 +45,10 @@
BrowserDistribution* distribution =
BrowserDistribution::GetSpecificDistribution(
BrowserDistribution::CHROME_BROWSER, prefs);
- EXPECT_TRUE(key.Open(root, distribution->GetStateKey().c_str(), KEY_READ));
- EXPECT_TRUE(key.ReadValue(installer::kInstallerSuccessLaunchCmdLine,
- &value));
+ EXPECT_EQ(ERROR_SUCCESS,
+ key.Open(root, distribution->GetStateKey().c_str(), KEY_READ));
+ EXPECT_EQ(ERROR_SUCCESS,
+ key.ReadValue(installer::kInstallerSuccessLaunchCmdLine, &value));
EXPECT_EQ(launch_cmd, value);
}
TempRegKeyOverride::DeleteAllTempKeys();
@@ -67,9 +68,10 @@
BrowserDistribution* distribution =
BrowserDistribution::GetSpecificDistribution(
BrowserDistribution::CHROME_BROWSER, prefs);
- EXPECT_TRUE(key.Open(root, distribution->GetStateKey().c_str(), KEY_READ));
- EXPECT_TRUE(key.ReadValue(installer::kInstallerSuccessLaunchCmdLine,
- &value));
+ EXPECT_EQ(ERROR_SUCCESS,
+ key.Open(root, distribution->GetStateKey().c_str(), KEY_READ));
+ EXPECT_EQ(ERROR_SUCCESS,
+ key.ReadValue(installer::kInstallerSuccessLaunchCmdLine, &value));
EXPECT_EQ(launch_cmd, value);
key.Close();
}
« no previous file with comments | « chrome/installer/util/install_util.cc ('k') | chrome/installer/util/installation_state.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698