Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10361)

Unified Diff: chrome/installer/util/delete_reg_value_work_item.h

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/delete_reg_value_work_item.h
===================================================================
--- chrome/installer/util/delete_reg_value_work_item.h (revision 71761)
+++ chrome/installer/util/delete_reg_value_work_item.h (working copy)
@@ -40,7 +40,7 @@
};
DeleteRegValueWorkItem(HKEY predefined_root, const std::wstring& key_path,
- const std::wstring& value_name, DWORD type);
+ const std::wstring& value_name);
// Root key of the target key under which the value is set. The root key can
// only be one of the predefined keys on Windows.
@@ -52,19 +52,11 @@
// Name of the value to be set.
std::wstring value_name_;
- // DWORD that tells whether data value is of type REG_SZ, REG_DWORD, or
- // REG_QWORD
- // Ideally we do not need this information from user of this class and can
- // check the registry for the type. But to simpify implementation we are
- // going to put the burden on the caller for now to provide us the type.
- DWORD type_;
-
DeletionStatus status_;
- // Data of the previous value.
- std::wstring old_str_; // if data is of type REG_SZ
- DWORD old_dw_; // if data is of type REG_DWORD
- int64 old_qword_; // if data is of type REG_QWORD
+ // Previous value.
+ DWORD previous_type_;
+ std::string previous_value_;
};
#endif // CHROME_INSTALLER_UTIL_DELETE_REG_VALUE_WORK_ITEM_H_
« no previous file with comments | « chrome/installer/util/delete_after_reboot_helper.cc ('k') | chrome/installer/util/delete_reg_value_work_item.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698