Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Unified Diff: chrome/common/chrome_plugin_lib.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/shell_dialogs_win.cc ('k') | chrome/installer/setup/chrome_frame_ready_mode.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/chrome_plugin_lib.cc
===================================================================
--- chrome/common/chrome_plugin_lib.cc (revision 71761)
+++ chrome/common/chrome_plugin_lib.cc (working copy)
@@ -153,11 +153,11 @@
reg_path.append(iter.Name());
base::win::RegKey key(HKEY_CURRENT_USER, reg_path.c_str());
- DWORD is_persistent;
- if (key.ReadValueDW(kRegistryLoadOnStartup, &is_persistent) &&
- is_persistent) {
+ DWORD is_persistent = 0;
+ key.ReadValueDW(kRegistryLoadOnStartup, &is_persistent);
+ if (is_persistent) {
std::wstring path;
- if (key.ReadValue(kRegistryPath, &path)) {
+ if (key.ReadValue(kRegistryPath, &path) == ERROR_SUCCESS) {
ChromePluginLib::Create(path, bfuncs);
}
}
« no previous file with comments | « chrome/browser/ui/views/shell_dialogs_win.cc ('k') | chrome/installer/setup/chrome_frame_ready_mode.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698