chrome/browser/extensions/external_registry_extension_loader_win.cc - Issue 6090006: Regkey functions return error code instead of bool

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_registry_extension_loader_win.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/external_registry_extension_loader_win.cc

===================================================================

--- chrome/browser/extensions/external_registry_extension_loader_win.cc (revision 71761)

+++ chrome/browser/extensions/external_registry_extension_loader_win.cc (working copy)

@@ -49,11 +49,13 @@

std::wstring key_path = ASCIIToWide(kRegistryExtensions);

key_path.append(L"\\");

key_path.append(iterator.Name());

- if (key.Open(kRegRoot, key_path.c_str(), KEY_READ)) {

+ if (key.Open(kRegRoot, key_path.c_str(), KEY_READ) == ERROR_SUCCESS) {

std::wstring extension_path;

- if (key.ReadValue(kRegistryExtensionPath, &extension_path)) {

+ if (key.ReadValue(kRegistryExtensionPath, &extension_path)

+ == ERROR_SUCCESS) {

std::wstring extension_version;

- if (key.ReadValue(kRegistryExtensionVersion, &extension_version)) {

+ if (key.ReadValue(kRegistryExtensionVersion, &extension_version)

+ == ERROR_SUCCESS) {

std::string id = WideToASCII(iterator.Name());

StringToLowerASCII(&id);