Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_frame/test/chrome_frame_test_utils.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome_frame/ready_mode/internal/registry_ready_mode_state.cc ('K') | « chrome_frame/ready_mode/internal/registry_ready_mode_state.cc ('k') | chrome_frame/test/perf/chrome_frame_perftest.cc » ('j') | chrome_frame/utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/test/chrome_frame_test_utils.cc
===================================================================
--- chrome_frame/test/chrome_frame_test_utils.cc (revision 71345)
+++ chrome_frame/test/chrome_frame_test_utils.cc (working copy)
@@ -633,8 +633,8 @@
DCHECK(temp_name && lstrlenW(temp_name));
std::wstring key_path(kTempTestKeyPath);
key_path += L"\\" + temp_name_;
- EXPECT_TRUE(temp_key_.Create(HKEY_CURRENT_USER, key_path.c_str(),
- KEY_ALL_ACCESS));
+ EXPECT_EQ(ERROR_SUCCESS, temp_key_.Create(HKEY_CURRENT_USER, key_path.c_str(),
+ KEY_ALL_ACCESS));
EXPECT_EQ(ERROR_SUCCESS,
::RegOverridePredefKey(override_, temp_key_.Handle()));
}
@@ -647,7 +647,7 @@
// static
void TempRegKeyOverride::DeleteAllTempKeys() {
base::win::RegKey key;
- if (key.Open(HKEY_CURRENT_USER, L"", KEY_ALL_ACCESS)) {
+ if (key.Open(HKEY_CURRENT_USER, L"", KEY_ALL_ACCESS) == ERROR_SUCCESS) {
key.DeleteKey(kTempTestKeyPath);
}
}
« chrome_frame/ready_mode/internal/registry_ready_mode_state.cc ('K') | « chrome_frame/ready_mode/internal/registry_ready_mode_state.cc ('k') | chrome_frame/test/perf/chrome_frame_perftest.cc » ('j') | chrome_frame/utils.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698