Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4799)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/installer/util/channel_info.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/create_reg_key_work_item.cc » ('j') | chrome/installer/util/delete_reg_value_work_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/channel_info.cc
===================================================================
--- chrome/installer/util/channel_info.cc (revision 70414)
+++ chrome/installer/util/channel_info.cc (working copy)
@@ -63,11 +63,12 @@
}
bool ChannelInfo::Initialize(const RegKey& key) {
- return key.ReadValue(google_update::kRegApField, &value_);
+ return key.ReadValue(google_update::kRegApField, &value_) == ERROR_SUCCESS;
}
bool ChannelInfo::Write(RegKey* key) const {
- return key->WriteValue(google_update::kRegApField, value_.c_str());
+ LONG result = key->WriteValue(google_update::kRegApField, value_.c_str());
+ return result == ERROR_SUCCESS;
}
bool ChannelInfo::GetChannelName(std::wstring* channel_name) const {
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/installer/setup/uninstall.cc ('k') | chrome/installer/util/create_reg_key_work_item.cc » ('j') | chrome/installer/util/delete_reg_value_work_item.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698