Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/browser/shell_integration_win.cc ('k') | chrome/browser/ui/views/shell_dialogs_win.cc » ('j') | chrome/installer/util/delete_reg_value_work_item.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/external_protocol_dialog.cc
===================================================================
--- chrome/browser/ui/views/external_protocol_dialog.cc (revision 70414)
+++ chrome/browser/ui/views/external_protocol_dialog.cc (working copy)
@@ -172,7 +172,7 @@
std::wstring parameters = url_spec.substr(split_offset + 1,
url_spec.length() - 1);
std::wstring application_to_launch;
- if (cmd_key.ReadValue(NULL, &application_to_launch)) {
+ if (cmd_key.ReadValue(NULL, &application_to_launch) == ERROR_SUCCESS) {
ReplaceSubstringsAfterOffset(&application_to_launch, 0, L"%1", parameters);
return application_to_launch;
} else {
« chrome/browser/policy/configuration_policy_provider_delegate_win.cc ('K') | « chrome/browser/shell_integration_win.cc ('k') | chrome/browser/ui/views/shell_dialogs_win.cc » ('j') | chrome/installer/util/delete_reg_value_work_item.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698