Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/extensions/external_registry_extension_provider_win.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_registry_extension_provider_win.cc
===================================================================
--- chrome/browser/extensions/external_registry_extension_provider_win.cc (revision 70414)
+++ chrome/browser/extensions/external_registry_extension_provider_win.cc (working copy)
@@ -29,7 +29,8 @@
key_path.append(L"\\");
key_path.append(ASCIIToWide(id));
- return key->Open(kRegRoot, key_path.c_str(), KEY_READ);
+ LONG result = key->Open(kRegRoot, key_path.c_str(), KEY_READ);
+ return (ERROR_SUCCESS == result);
}
} // namespace
@@ -49,11 +50,13 @@
std::wstring key_path = ASCIIToWide(kRegistryExtensions);
key_path.append(L"\\");
key_path.append(iterator.Name());
- if (key.Open(kRegRoot, key_path.c_str(), KEY_READ)) {
+ if (key.Open(kRegRoot, key_path.c_str(), KEY_READ) == ERROR_SUCCESS) {
std::wstring extension_path;
- if (key.ReadValue(kRegistryExtensionPath, &extension_path)) {
+ if (key.ReadValue(kRegistryExtensionPath,
+ &extension_path) == ERROR_SUCCESS) {
std::wstring extension_version;
- if (key.ReadValue(kRegistryExtensionVersion, &extension_version)) {
+ if (key.ReadValue(kRegistryExtensionVersion,
+ &extension_version) == ERROR_SUCCESS) {
std::string id = WideToASCII(iterator.Name());
StringToLowerASCII(&id);
@@ -101,7 +104,8 @@
return false;
std::wstring extension_version;
- if (!key.ReadValue(kRegistryExtensionVersion, &extension_version))
+ if (key.ReadValue(kRegistryExtensionVersion,
+ &extension_version) != ERROR_SUCCESS)
return false;
if (version) {

Powered by Google App Engine
This is Rietveld 408576698