Index: chrome/app/breakpad_win.cc |
=================================================================== |
--- chrome/app/breakpad_win.cc (revision 70414) |
+++ chrome/app/breakpad_win.cc (working copy) |
@@ -437,17 +437,18 @@ |
// contains the value set by policy. |
static bool MetricsReportingControlledByPolicy(bool* result) { |
std::wstring key_name = UTF8ToWide(policy::key::kMetricsReportingEnabled); |
- DWORD value; |
+ DWORD value = 0; |
+ // TODO(joshia): why hkcu_policy_key opens HKEY_LOCAL_MACHINE? |
base::win::RegKey hkcu_policy_key(HKEY_LOCAL_MACHINE, |
policy::kRegistrySubKey, KEY_READ); |
- if (hkcu_policy_key.ReadValueDW(key_name.c_str(), &value)) { |
+ if (hkcu_policy_key.ReadValueDW(key_name.c_str(), &value) == ERROR_SUCCESS) { |
*result = value != 0; |
return true; |
} |
base::win::RegKey hklm_policy_key(HKEY_CURRENT_USER, |
policy::kRegistrySubKey, KEY_READ); |
- if (hklm_policy_key.ReadValueDW(key_name.c_str(), &value)) { |
+ if (hklm_policy_key.ReadValueDW(key_name.c_str(), &value) == ERROR_SUCCESS) { |
*result = value != 0; |
return true; |
} |