Regkey functions return error code instead of bool

net/base/ssl_config_service_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/ssl_config_service_win.h"
 
 #include "base/threading/thread_restrictions.h"
 #include "base/win/registry.h"
 
 using base::TimeDelta;
@@ skipping 45 matching lines @@
     UpdateConfig(now);
   *config = config_info_;
 }
 
 // static
 bool SSLConfigServiceWin::GetSSLConfigNow(SSLConfig* config) {
   // This registry access goes to disk and will slow down the IO thread.
   // http://crbug.com/61455
   base::ThreadRestrictions::ScopedAllowIO allow_io;
   RegKey internet_settings;
-  if (!internet_settings.Open(HKEY_CURRENT_USER, kInternetSettingsSubKeyName,
-                              KEY_READ))
+  LONG result = internet_settings.Open(HKEY_CURRENT_USER,
+                                       kInternetSettingsSubKeyName, KEY_READ);
+  if (result != ERROR_SUCCESS)
     return false;
 
-  DWORD revocation;
-  if (!internet_settings.ReadValueDW(kRevocationValueName, &revocation))
-    revocation = REVOCATION_DEFAULT;
+  DWORD revocation = REVOCATION_DEFAULT;
+  internet_settings.ReadValueDW(kRevocationValueName, &revocation);
 
-  DWORD protocols;
-  if (!internet_settings.ReadValueDW(kProtocolsValueName, &protocols))
-    protocols = PROTOCOLS_DEFAULT;
+  DWORD protocols = PROTOCOLS_DEFAULT;
+  internet_settings.ReadValueDW(kProtocolsValueName, &protocols);
 
   config->rev_checking_enabled = (revocation != 0);
   config->ssl3_enabled = ((protocols & SSL3) != 0);
   config->tls1_enabled = ((protocols & TLS1) != 0);
   SSLConfigService::SetSSLConfigFlags(config);
 
   // TODO(rsleevi): Possibly respect the registry keys defined in
   // http://support.microsoft.com/kb/245030 (pre-Vista) or
   // http://msdn.microsoft.com/en-us/library/bb870930(VS.85).aspx (post-Vista).
   // Currently, these values are respected implicitly when using
@@ skipping 26 matching lines @@
   SetSSLVersionEnabled(TLS1, enabled);
 }
 
 // static
 void SSLConfigServiceWin::SetSSLVersionEnabled(int version, bool enabled) {
   // This registry access goes to disk and will slow down the IO thread.
   // http://crbug.com/61455
   base::ThreadRestrictions::ScopedAllowIO allow_io;
   RegKey internet_settings(HKEY_CURRENT_USER, kInternetSettingsSubKeyName,
                            KEY_READ | KEY_WRITE);
-  DWORD value;
-  if (!internet_settings.ReadValueDW(kProtocolsValueName, &value))
-    value = PROTOCOLS_DEFAULT;
+  DWORD value = PROTOCOLS_DEFAULT;
+  internet_settings.ReadValueDW(kProtocolsValueName, &value);
+
   if (enabled)
     value |= version;
   else
     value &= ~version;
   internet_settings.WriteValue(kProtocolsValueName, value);
   // TODO(mattm): We should call UpdateConfig after updating settings, but these
   // methods are static.
 }
 
 void SSLConfigServiceWin::UpdateConfig(TimeTicks now) {
   SSLConfig orig_config = config_info_;
   GetSSLConfigNow(&config_info_);
   if (ever_updated_)
     ProcessConfigUpdate(orig_config, config_info_);
   config_time_ = now;
   ever_updated_ = true;
 }
 
 }  // namespace net