Regkey functions return error code instead of bool

chrome_frame/test/policy_settings_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 #include "base/at_exit.h"
 #include "base/logging.h"
 #include "base/scoped_ptr.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
 #include "base/win/registry.h"
 #include "chrome/common/policy_constants.h"
 #include "chrome_frame/policy_settings.h"
 #include "chrome_frame/test/chrome_frame_test_utils.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::win::RegKey;
 using chrome_frame_test::ScopedVirtualizeHklmAndHkcu;
 using chrome_frame_test::TempRegKeyOverride;
 
 namespace {
 
 // A best effort way to zap CF policy entries that may be in the registry.
 void DeleteChromeFramePolicyEntries(HKEY root) {
   RegKey key;
-  if (key.Open(root, policy::kRegistrySubKey, KEY_ALL_ACCESS)) {
+  if (key.Open(root, policy::kRegistrySubKey,
+               KEY_ALL_ACCESS) == ERROR_SUCCESS) {
     key.DeleteValue(
         ASCIIToWide(policy::key::kChromeFrameRendererSettings).c_str());
     key.DeleteKey(ASCIIToWide(policy::key::kRenderInChromeFrameList).c_str());
     key.DeleteKey(ASCIIToWide(policy::key::kRenderInHostList).c_str());
     key.DeleteKey(ASCIIToWide(policy::key::kChromeFrameContentTypes).c_str());
     key.DeleteKey(ASCIIToWide(policy::key::kApplicationLocaleValue).c_str());
   }
 }
 
 bool InitializePolicyKey(HKEY policy_root, RegKey* policy_key) {
-  EXPECT_TRUE(policy_key->Create(policy_root, policy::kRegistrySubKey,
-                                 KEY_ALL_ACCESS));
+  EXPECT_EQ(ERROR_SUCCESS, policy_key->Create(policy_root,
+      policy::kRegistrySubKey, KEY_ALL_ACCESS));
   return policy_key->Valid();
 }
 
 void WritePolicyList(RegKey* policy_key, const wchar_t* list_name,
                      const wchar_t* values[], int count) {
   DCHECK(policy_key);
   // Remove any previous settings
   policy_key->DeleteKey(list_name);
 
   RegKey list_key;
-  EXPECT_TRUE(list_key.Create(policy_key->Handle(), list_name, KEY_ALL_ACCESS));
+  EXPECT_EQ(ERROR_SUCCESS, list_key.Create(policy_key->Handle(), list_name,
+                                           KEY_ALL_ACCESS));
   for (int i = 0; i < count; ++i) {
-    EXPECT_TRUE(list_key.WriteValue(base::StringPrintf(L"%i", i).c_str(),
-                                    values[i]));
+    EXPECT_EQ(ERROR_SUCCESS,
+        list_key.WriteValue(base::StringPrintf(L"%i", i).c_str(), values[i]));
   }
 }
 
 bool SetRendererSettings(HKEY policy_root,
                          PolicySettings::RendererForUrl renderer,
                          const wchar_t* exclusions[],
                          int exclusion_count) {
   RegKey policy_key;
   if (!InitializePolicyKey(policy_root, &policy_key))
     return false;
@@ skipping 24 matching lines @@
   return true;
 }
 
 bool SetChromeApplicationLocale(HKEY policy_root, const wchar_t* locale) {
   RegKey policy_key;
   if (!InitializePolicyKey(policy_root, &policy_key))
     return false;
 
   std::wstring application_locale_value(
       ASCIIToWide(policy::key::kApplicationLocaleValue));
-  EXPECT_TRUE(policy_key.WriteValue(application_locale_value.c_str(), locale));
+  EXPECT_EQ(ERROR_SUCCESS,
+      policy_key.WriteValue(application_locale_value.c_str(), locale));
   return true;
 }
 
 }  // end namespace
 
 class PolicySettingsTest : public testing::Test {
  protected:
   void SetUp() {
     ResetPolicySettings();
   }
@@ skipping 97 matching lines @@
   HKEY root[] = { HKEY_LOCAL_MACHINE, HKEY_CURRENT_USER };
   for (int i = 0; i < arraysize(root); ++i) {
     SetChromeApplicationLocale(root[i], kTestApplicationLocale);
     ResetPolicySettings();
     EXPECT_EQ(std::wstring(kTestApplicationLocale),
               PolicySettings::GetInstance()->ApplicationLocale());
 
     DeleteChromeFramePolicyEntries(root[i]);
   }
 }