Regkey functions return error code instead of bool

chrome/installer/util/product_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/product_unittest.h"
 
 #include "base/logging.h"
 #include "base/utf_string_conversions.h"
 #include "chrome/installer/util/chrome_frame_distribution.h"
 #include "chrome/installer/util/google_update_constants.h"
@@ skipping 35 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 const wchar_t TempRegKeyOverride::kTempTestKeyPath[] =
     L"Software\\Chromium\\TempTestKeys";
 
 TempRegKeyOverride::TempRegKeyOverride(HKEY override, const wchar_t* temp_name)
     : override_(override), temp_name_(temp_name) {
   DCHECK(temp_name && lstrlenW(temp_name));
   std::wstring key_path(kTempTestKeyPath);
   key_path += L"\\" + temp_name_;
-  EXPECT_TRUE(temp_key_.Create(HKEY_CURRENT_USER, key_path.c_str(),
-                               KEY_ALL_ACCESS));
+  EXPECT_EQ(ERROR_SUCCESS,
+      temp_key_.Create(HKEY_CURRENT_USER, key_path.c_str(), KEY_ALL_ACCESS));
   EXPECT_EQ(ERROR_SUCCESS,
             ::RegOverridePredefKey(override_, temp_key_.Handle()));
 }
 
 TempRegKeyOverride::~TempRegKeyOverride() {
   ::RegOverridePredefKey(override_, NULL);
   // The temp key will be deleted via a call to DeleteAllTempKeys().
 }
 
 // static
 void TempRegKeyOverride::DeleteAllTempKeys() {
   RegKey key;
-  if (key.Open(HKEY_CURRENT_USER, L"", KEY_ALL_ACCESS)) {
+  if (key.Open(HKEY_CURRENT_USER, L"", KEY_ALL_ACCESS) == ERROR_SUCCESS) {
     key.DeleteKey(kTempTestKeyPath);
   }
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 
 class ProductTest : public TestWithTempDirAndDeleteTempOverrideKeys {
  protected:
 };
 
@@ skipping 26 matching lines @@
   // We started out with a non-msi product.
   EXPECT_FALSE(product->IsMsi());
 
   HKEY root = system_level ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   {
     TempRegKeyOverride override(root, L"root_pit");
 
     // Create a make-believe client state key.
     RegKey key;
     std::wstring state_key_path(distribution->GetStateKey());
-    ASSERT_TRUE(key.Create(root, state_key_path.c_str(), KEY_ALL_ACCESS));
+    ASSERT_EQ(ERROR_SUCCESS,
+        key.Create(root, state_key_path.c_str(), KEY_ALL_ACCESS));
 
     // Set the MSI marker, delete the objects, create new ones and verify
     // that we now see the MSI marker.
     EXPECT_TRUE(product->SetMsiMarker(true));
     package = new Package(multi_install, system_level, test_dir_.path(),
                           &properties);
     product = new Product(distribution, package.get());
     EXPECT_TRUE(product->IsMsi());
 
     // There should be no installed version in the registry.
@@ skipping 64 matching lines @@
 
   installs.AddDistribution(BrowserDistribution::CHROME_BROWSER, prefs);
   FakeChromeFrameDistribution fake_chrome_frame(prefs);
   installs.AddDistribution(&fake_chrome_frame);
   EXPECT_EQ(2U, installs.products().size());
   // Since our fake Chrome Frame distribution class is reporting the same
   // installation directory as Chrome, we should have only one package object.
   EXPECT_EQ(1U, installs.packages().size());
   EXPECT_EQ(multi_install, installs.packages()[0]->multi_install());
 }