Regkey functions return error code instead of bool

chrome/browser/first_run/first_run_win.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/first_run/first_run.h"
 
 #include <windows.h>
 #include <shellapi.h>
 #include <shlobj.h>
 
@@ skipping 261 matching lines @@
   if (!PathService::Get(base::FILE_EXE, &cur_chrome_exe))
     return false;
 
   // First try to rename exe by launching rename command ourselves.
   bool user_install =
       InstallUtil::IsPerUserInstall(cur_chrome_exe.value().c_str());
   HKEY reg_root = user_install ? HKEY_CURRENT_USER : HKEY_LOCAL_MACHINE;
   BrowserDistribution *dist = BrowserDistribution::GetDistribution();
   base::win::RegKey key;
   std::wstring rename_cmd;
-  if (key.Open(reg_root, dist->GetVersionKey().c_str(), KEY_READ) &&
-      key.ReadValue(google_update::kRegRenameCmdField, &rename_cmd)) {
-    base::ProcessHandle handle;
-    if (base::LaunchApp(rename_cmd, true, true, &handle)) {
-      DWORD exit_code;
-      ::GetExitCodeProcess(handle, &exit_code);
-      ::CloseHandle(handle);
-      if (exit_code == installer::RENAME_SUCCESSFUL)
-        return true;
+  LONG result = key.Open(reg_root, dist->GetVersionKey().c_str(), KEY_READ);
+  if (result == ERROR_SUCCESS) {
+    result = key.ReadValue(google_update::kRegRenameCmdField, &rename_cmd);
+    if (result == ERROR_SUCCESS) {
+      base::ProcessHandle handle;
+      if (base::LaunchApp(rename_cmd, true, true, &handle)) {
+        DWORD exit_code;
+        ::GetExitCodeProcess(handle, &exit_code);
+        ::CloseHandle(handle);
+        if (exit_code == installer::RENAME_SUCCESSFUL)
+          return true;
+      }
     }
   }
 
   // Rename didn't work so try to rename by calling Google Update
   return InvokeGoogleUpdateForRename();
 }
 
 // static
 bool Upgrade::DoUpgradeTasks(const CommandLine& command_line) {
   if (!Upgrade::SwapNewChromeExeIfPresent())
@@ skipping 554 matching lines @@
 
 Upgrade::TryResult Upgrade::ShowTryChromeDialog(size_t version) {
   if (version > 10000) {
     // This is a test value. We want to make sure we exercise
     // returning this early. See EarlyReturnTest test harness.
     return Upgrade::TD_NOT_NOW;
   }
   TryChromeDialog td(version);
   return td.ShowModal();
 }