Regkey functions return error code instead of bool

chrome/installer/util/installation_state.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/installation_state.h"
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/version.h"
 #include "base/win/registry.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/package_properties.h"
 
 namespace installer {
 
 ProductState::ProductState() {
 }
 
 void ProductState::Initialize(bool system_install,
                               const std::wstring& version_key,
                               const std::wstring& state_key) {
   const HKEY root_key = system_install ? HKEY_LOCAL_MACHINE : HKEY_CURRENT_USER;
   base::win::RegKey key(root_key, version_key.c_str(), KEY_QUERY_VALUE);
   std::wstring version_str;
-  if (key.ReadValue(google_update::kRegVersionField, &version_str)) {
+  if (key.ReadValue(google_update::kRegVersionField, &version_str)
+      == ERROR_SUCCESS) {

[grt (UTC plus 2), 2011/01/16 04:19:48]

Wrapping

[amit, 2011/01/16 07:54:28]

Done.

     version_.reset(Version::GetVersionFromString(WideToASCII(version_str)));
     if (version_.get() != NULL) {
       // The product is installed.  Check for the channel value (absent if not
       // installed/managed by Google Update).
-      if (!key.Open(root_key, state_key.c_str(), KEY_QUERY_VALUE) ||
-          !channel_.Initialize(key)) {
+      if (key.Open(root_key, state_key.c_str(), KEY_QUERY_VALUE)
+          != ERROR_SUCCESS || !channel_.Initialize(key)) {

[grt (UTC plus 2), 2011/01/16 04:19:48]

Wrapping (plus extra parens around the first part?)

[amit, 2011/01/16 07:54:28]

Done.

         channel_.set_value(std::wstring());
       }
     }
   } else {
     version_.reset();
   }
 }
 
 const Version& ProductState::version() const {
   DCHECK(version_.get() != NULL);
@@ skipping 68 matching lines @@
 
 const ProductState* InstallationState::GetProductState(
     bool system_install,
     BrowserDistribution::Type type) const {
   const ProductState& product_state = (system_install ? system_products_ :
       user_products_)[IndexFromDistType(type)];
   return product_state.version_.get() == NULL ? NULL : &product_state;
 }
 
 }  // namespace installer