Regkey functions return error code instead of bool

chrome/installer/util/channel_info.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/channel_info.h"
 
 #include "base/logging.h"
 #include "base/win/registry.h"
 #include "chrome/installer/util/google_update_constants.h"
 
@@ skipping 98 matching lines @@
     }
   }
   return false;
 }
 
 }  // namespace
 
 namespace installer {
 
 bool ChannelInfo::Initialize(const RegKey& key) {
-  return key.ReadValue(google_update::kRegApField, &value_);
+  return (key.ReadValue(google_update::kRegApField, &value_) == ERROR_SUCCESS);
 }
 
 bool ChannelInfo::Write(RegKey* key) const {
-  return key->WriteValue(google_update::kRegApField, value_.c_str());
+  return (key->WriteValue(google_update::kRegApField, value_.c_str())
+      == ERROR_SUCCESS);

[grt (UTC plus 2), 2011/01/16 04:19:48]

Wrapping and indentation.

[amit, 2011/01/16 07:54:28]

Done.

 }
 
 bool ChannelInfo::GetChannelName(std::wstring* channel_name) const {
   DCHECK(channel_name);
   if (value_.empty()) {
     channel_name->erase();
     return true;
   } else {
     for (const wchar_t* const* scan = &kChannels[0],
              *const* end = &kChannels[arraysize(kChannels)]; scan != end;
@@ skipping 68 matching lines @@
 
 bool ChannelInfo::HasMultiFailSuffix() const {
   return HasModifier(SFX_MULTI_FAIL, value_);
 }
 
 bool ChannelInfo::SetMultiFailSuffix(bool value) {
   return SetModifier(SFX_MULTI_FAIL, value, &value_);
 }
 
 }  // namespace installer