Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Side by Side Diff: chrome/installer/util/work_item_list.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/installer/util/work_item_list.h" 5 #include "chrome/installer/util/work_item_list.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/file_path.h" 8 #include "base/file_path.h"
9 #include "chrome/installer/util/logging_installer.h" 9 #include "chrome/installer/util/logging_installer.h"
10 #include "chrome/installer/util/copy_tree_work_item.h" 10 #include "chrome/installer/util/copy_tree_work_item.h"
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 WorkItem* WorkItemList::AddDeleteRegKeyWorkItem(HKEY predefined_root, 103 WorkItem* WorkItemList::AddDeleteRegKeyWorkItem(HKEY predefined_root,
104 const std::wstring& path) { 104 const std::wstring& path) {
105 WorkItem* item = WorkItem::CreateDeleteRegKeyWorkItem(predefined_root, path); 105 WorkItem* item = WorkItem::CreateDeleteRegKeyWorkItem(predefined_root, path);
106 AddWorkItem(item); 106 AddWorkItem(item);
107 return item; 107 return item;
108 } 108 }
109 109
110 WorkItem* WorkItemList::AddDeleteRegValueWorkItem( 110 WorkItem* WorkItemList::AddDeleteRegValueWorkItem(
111 HKEY predefined_root, 111 HKEY predefined_root,
112 const std::wstring& key_path, 112 const std::wstring& key_path,
113 const std::wstring& value_name, 113 const std::wstring& value_name) {
114 DWORD type) {
115 WorkItem* item = WorkItem::CreateDeleteRegValueWorkItem(predefined_root, 114 WorkItem* item = WorkItem::CreateDeleteRegValueWorkItem(predefined_root,
116 key_path, 115 key_path, value_name);
117 value_name,
118 type);
119 AddWorkItem(item); 116 AddWorkItem(item);
120 return item; 117 return item;
121 } 118 }
122 119
123 WorkItem* WorkItemList::AddDeleteTreeWorkItem( 120 WorkItem* WorkItemList::AddDeleteTreeWorkItem(
124 const FilePath& root_path, 121 const FilePath& root_path,
125 const std::vector<FilePath>& key_paths) { 122 const std::vector<FilePath>& key_paths) {
126 WorkItem* item = WorkItem::CreateDeleteTreeWorkItem(root_path, key_paths); 123 WorkItem* item = WorkItem::CreateDeleteTreeWorkItem(root_path, key_paths);
127 AddWorkItem(item); 124 AddWorkItem(item);
128 return item; 125 return item;
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
215 VLOG(1) << "NoRollbackWorkItemList: list execution succeeded"; 212 VLOG(1) << "NoRollbackWorkItemList: list execution succeeded";
216 213
217 status_ = LIST_EXECUTED; 214 status_ = LIST_EXECUTED;
218 return result; 215 return result;
219 } 216 }
220 217
221 void NoRollbackWorkItemList::Rollback() { 218 void NoRollbackWorkItemList::Rollback() {
222 NOTREACHED() << "Can't rollback a NoRollbackWorkItemList"; 219 NOTREACHED() << "Can't rollback a NoRollbackWorkItemList";
223 } 220 }
224 221
OLDNEW
« no previous file with comments | « chrome/installer/util/work_item_list.h ('k') | chrome/installer/util/work_item_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698