Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: ceee/ie/common/ie_util_unittest.cc

Issue 6090006: Regkey functions return error code instead of bool (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ceee/ie/common/ie_util.cc ('k') | ceee/ie/plugin/toolband/toolband_proxy.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Unit tests for the CEEE IE utilities. 5 // Unit tests for the CEEE IE utilities.
6 6
7 #include "ceee/ie/common/ie_util.h" 7 #include "ceee/ie/common/ie_util.h"
8 8
9 #include "base/scoped_ptr.h" 9 #include "base/scoped_ptr.h"
10 #include "ceee/testing/utils/mock_static.h" 10 #include "ceee/testing/utils/mock_static.h"
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 TEST_F(IeUtilTest, Ie8) { 63 TEST_F(IeUtilTest, Ie8) {
64 MockIeUtil ie_util_mock; 64 MockIeUtil ie_util_mock;
65 EXPECT_CALL(ie_util_mock, GetIeVersion()) 65 EXPECT_CALL(ie_util_mock, GetIeVersion())
66 .WillRepeatedly(Return(ie_util::IEVERSION_IE8)); 66 .WillRepeatedly(Return(ie_util::IEVERSION_IE8));
67 67
68 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid)); 68 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid));
69 69
70 base::win::RegKey stats_key(HKEY_CURRENT_USER, kAddonStatsRegPath, KEY_WRITE); 70 base::win::RegKey stats_key(HKEY_CURRENT_USER, kAddonStatsRegPath, KEY_WRITE);
71 ASSERT_TRUE(stats_key.Valid()); 71 ASSERT_TRUE(stats_key.Valid());
72 72
73 ASSERT_TRUE(stats_key.WriteValue(L"LoadTime", L"time")); 73 ASSERT_EQ(ERROR_SUCCESS, stats_key.WriteValue(L"LoadTime", L"time"));
74 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid)); 74 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid));
75 75
76 DWORD time = 11; 76 DWORD time = 11;
77 ASSERT_TRUE(stats_key.WriteValue(L"LoadTime", time)); 77 ASSERT_EQ(ERROR_SUCCESS, stats_key.WriteValue(L"LoadTime", time));
78 78
79 EXPECT_EQ(11, GetAverageAddonLoadTimeMs(kAddonGuid)); 79 EXPECT_EQ(11, GetAverageAddonLoadTimeMs(kAddonGuid));
80 } 80 }
81 81
82 TEST_F(IeUtilTest, Ie9) { 82 TEST_F(IeUtilTest, Ie9) {
83 MockIeUtil ie_util_mock; 83 MockIeUtil ie_util_mock;
84 EXPECT_CALL(ie_util_mock, GetIeVersion()) 84 EXPECT_CALL(ie_util_mock, GetIeVersion())
85 .WillRepeatedly(Return(ie_util::IEVERSION_IE9)); 85 .WillRepeatedly(Return(ie_util::IEVERSION_IE9));
86 86
87 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid)); 87 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid));
88 88
89 base::win::RegKey stats_key(HKEY_CURRENT_USER, kAddonStatsRegPath, KEY_WRITE); 89 base::win::RegKey stats_key(HKEY_CURRENT_USER, kAddonStatsRegPath, KEY_WRITE);
90 ASSERT_TRUE(stats_key.Valid()); 90 ASSERT_TRUE(stats_key.Valid());
91 91
92 ASSERT_TRUE(stats_key.WriteValue(L"LoadTimeArray", L"time")); 92 ASSERT_EQ(ERROR_SUCCESS, stats_key.WriteValue(L"LoadTimeArray", L"time"));
93 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid)); 93 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid));
94 94
95 DWORD time[] = {1, 2, 3, 4, -1, 10}; 95 DWORD time[] = {1, 2, 3, 4, -1, 10};
96 96
97 ASSERT_TRUE(stats_key.WriteValue(L"LoadTimeArray", &time, sizeof(time[0]), 97 ASSERT_EQ(ERROR_SUCCESS, stats_key.WriteValue(L"LoadTimeArray", &time,
98 REG_BINARY)); 98 sizeof(time[0]), REG_BINARY));
99 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid)); 99 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid));
100 100
101 ASSERT_TRUE(stats_key.WriteValue(L"LoadTimeArray", &time, 10, REG_BINARY)); 101 ASSERT_EQ(ERROR_SUCCESS,
102 stats_key.WriteValue(L"LoadTimeArray", &time, 10, REG_BINARY));
102 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid)); 103 EXPECT_EQ(-1, GetAverageAddonLoadTimeMs(kAddonGuid));
103 104
104 ASSERT_TRUE(stats_key.WriteValue(L"LoadTimeArray", &time, 4 * sizeof(time[0]), 105 ASSERT_EQ(ERROR_SUCCESS, stats_key.WriteValue(L"LoadTimeArray",
105 REG_BINARY)); 106 &time, 4 * sizeof(time[0]), REG_BINARY));
106 EXPECT_EQ(2, GetAverageAddonLoadTimeMs(kAddonGuid)); 107 EXPECT_EQ(2, GetAverageAddonLoadTimeMs(kAddonGuid));
107 108
108 ASSERT_TRUE(stats_key.WriteValue(L"LoadTimeArray", time, sizeof(time), 109 ASSERT_EQ(ERROR_SUCCESS, stats_key.WriteValue(L"LoadTimeArray", time,
109 REG_BINARY)); 110 sizeof(time), REG_BINARY));
110 EXPECT_EQ(4, GetAverageAddonLoadTimeMs(kAddonGuid)); 111 EXPECT_EQ(4, GetAverageAddonLoadTimeMs(kAddonGuid));
111 } 112 }
112 113
113 } // namespace 114 } // namespace
OLDNEW
« no previous file with comments | « ceee/ie/common/ie_util.cc ('k') | ceee/ie/plugin/toolband/toolband_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698