Regkey functions return error code instead of bool

chrome_frame/test/chrome_frame_test_utils.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/test/chrome_frame_test_utils.h"
 
 #include <atlbase.h>
 #include <atlwin.h>
 #include <iepmapi.h>
 #include <sddl.h>
@@ skipping 614 matching lines @@
     }
     return NULL;
   }
 }
 
 TempRegKeyOverride::TempRegKeyOverride(HKEY override, const wchar_t* temp_name)
     : override_(override), temp_name_(temp_name) {
   DCHECK(temp_name && lstrlenW(temp_name));
   std::wstring key_path(kTempTestKeyPath);
   key_path += L"\\" + temp_name_;
-  EXPECT_TRUE(temp_key_.Create(HKEY_CURRENT_USER, key_path.c_str(),
-                               KEY_ALL_ACCESS));
+  EXPECT_EQ(ERROR_SUCCESS, temp_key_.Create(HKEY_CURRENT_USER, key_path.c_str(),
+                                            KEY_ALL_ACCESS));
   EXPECT_EQ(ERROR_SUCCESS,
             ::RegOverridePredefKey(override_, temp_key_.Handle()));
 }
 
 TempRegKeyOverride::~TempRegKeyOverride() {
   ::RegOverridePredefKey(override_, NULL);
   // The temp key will be deleted via a call to DeleteAllTempKeys().
 }
 
 // static
 void TempRegKeyOverride::DeleteAllTempKeys() {
   base::win::RegKey key;
-  if (key.Open(HKEY_CURRENT_USER, L"", KEY_ALL_ACCESS)) {
+  if (key.Open(HKEY_CURRENT_USER, L"", KEY_ALL_ACCESS) == ERROR_SUCCESS) {
     key.DeleteKey(kTempTestKeyPath);
   }
 }
 
 ScopedVirtualizeHklmAndHkcu::ScopedVirtualizeHklmAndHkcu() {
   TempRegKeyOverride::DeleteAllTempKeys();
   hklm_.reset(new TempRegKeyOverride(HKEY_LOCAL_MACHINE, L"hklm_fake"));
   hkcu_.reset(new TempRegKeyOverride(HKEY_CURRENT_USER, L"hkcu_fake"));
 }
 
 ScopedVirtualizeHklmAndHkcu::~ScopedVirtualizeHklmAndHkcu() {
   hkcu_.reset(NULL);
   hklm_.reset(NULL);
   TempRegKeyOverride::DeleteAllTempKeys();
 }
 
 bool KillProcesses(const std::wstring& executable_name, int exit_code,
                    bool wait) {
   bool result = true;
   base::NamedProcessIterator iter(executable_name, NULL);
   while (const base::ProcessEntry* entry = iter.NextProcessEntry()) {
     result &= base::KillProcessById(entry->pid(), exit_code, wait);
   }
   return result;
 }
 
 }  // namespace chrome_frame_test