Regkey functions return error code instead of bool

ceee/ie/common/ie_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Utility functions to interact with IE.
 
 #include "ceee/ie/common/ie_util.h"
 
 #include <atlcomcli.h>
 #include <exdisp.h>  // IWebBrowser2
@@ skipping 25 matching lines @@
   return enum_punk->QueryInterface(IID_IEnumVARIANT,
                                    reinterpret_cast<void**>(enum_windows));
 }
 
 bool GetIeVersionString(std::wstring* version) {
   DCHECK(version != NULL);
   if (version == NULL)
     return false;
   base::win::RegKey key(HKEY_LOCAL_MACHINE, kIeVersionKey, KEY_READ);
   DCHECK(key.ValueExists(kIeVersionValue));
-  return key.ReadValue(kIeVersionValue, version);
+  return key.ReadValue(kIeVersionValue, version) == ERROR_SUCCESS;
 }
 
 }  // namespace
 
 namespace ie_util {
 
 HRESULT GetWebBrowserForTopLevelIeHwnd(
     HWND window, IWebBrowser2* not_him, IWebBrowser2** browser) {
   DCHECK(browser != NULL);
   CComPtr<IEnumVARIANT> enum_windows;
@@ skipping 101 matching lines @@
   key_name += L"\\iexplore";
 
   base::win::RegKey stats_key(HKEY_CURRENT_USER, key_name.c_str(), KEY_READ);
   if (!stats_key.Valid()) {
     LOG(ERROR) << "Missing stats key: " << key_name;
     return kInvalidTime;
   }
 
   DWORD load_time = 0;
   if (GetIeVersion() < IEVERSION_IE9) {
-    if (!stats_key.ReadValueDW(time_prefix.c_str(), &load_time)) {
+    LONG result = stats_key.ReadValueDW(time_prefix.c_str(), &load_time);

[Sigurður Ásgeirsson, 2011/01/10 21:02:43]

ugh, I guess we rely on this everywhere. Can I still ask you to document and
test this? 

+    if (result != ERROR_SUCCESS) {
       VLOG(1) << "Can't read time: " << time_prefix;
       return kInvalidTime;
     }
   } else {
     std::wstring value_name(time_prefix);
     value_name += L"Array";
     DWORD count = 0;
     int32 values[100];
     DWORD data_size = sizeof(values);
     DWORD data_type = REG_NONE;
 
-    if (!stats_key.ReadValue(value_name.c_str(), &values, &data_size,
-                             &data_type)) {
+    LONG result = stats_key.ReadValue(value_name.c_str(), &values, &data_size,
+                                      &data_type);
+    if (result != ERROR_SUCCESS) {
       VLOG(1) << "Can't read time: " << value_name;

[Sigurður Ásgeirsson, 2011/01/10 21:02:43]

com::LogWe(result) now that we have the error in question, please?

[amit, 2011/01/12 04:11:23]

Done.

       return kInvalidTime;
     }
 
     if (data_type != REG_BINARY) {
       LOG(ERROR) << "Unexpected data type:" << data_type;
       return kInvalidTime;
     }
 
     if (data_size % sizeof(values[0]) != 0) {
       LOG(ERROR) << "Unexpected data length:" << data_size;
@@ skipping 22 matching lines @@
 
   if (load_time < 0) {
     LOG(ERROR) << "Invalid time:" << load_time;
     return kInvalidTime;
   }
 
   return load_time;
 }
 
 }  // namespace ie_util