[Chrome OS] Respect periods in google apps account names

chrome/browser/chromeos/login/authenticator_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/authenticator.h"
 
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace chromeos {
 
 TEST(AuthenticatorTest, EmailAddressNoOp) {
   const char lower_case[] = "user@what.com";
   EXPECT_EQ(lower_case, Authenticator::Canonicalize(lower_case));
 }
 
 TEST(AuthenticatorTest, EmailAddressIgnoreCaps) {
   EXPECT_EQ(Authenticator::Canonicalize("user@what.com"),
             Authenticator::Canonicalize("UsEr@what.com"));
 }
 
 TEST(AuthenticatorTest, EmailAddressIgnoreDomainCaps) {
   EXPECT_EQ(Authenticator::Canonicalize("user@what.com"),
             Authenticator::Canonicalize("UsEr@what.COM"));
 }
 
-TEST(AuthenticatorTest, EmailAddressIgnoreOneUsernameDot) {
-  EXPECT_EQ(Authenticator::Canonicalize("us.er@what.com"),
+TEST(AuthenticatorTest, EmailAddressRejectOneUsernameDot) {
+  EXPECT_NE(Authenticator::Canonicalize("u.ser@what.com"),
             Authenticator::Canonicalize("UsEr@what.com"));
 }
 
+TEST(AuthenticatorTest, EmailAddressMatchWithOneUsernameDot) {
+  EXPECT_EQ(Authenticator::Canonicalize("u.ser@what.com"),
+            Authenticator::Canonicalize("U.sEr@what.com"));
+}
+
+TEST(AuthenticatorTest, EmailAddressIgnoreOneUsernameDot) {
+  std::string first("us.er@");
+  first.append(Authenticator::kSpecialCase);

[whywhat, 2010/12/30 17:37:39]

I'd just use "gmail.com" here to improve readability a little bit.

[Chris Masone, 2010/12/30 18:52:50]

ok.

+  std::string second("UsEr@");
+  second.append(Authenticator::kSpecialCase);
+  EXPECT_EQ(Authenticator::Canonicalize(first),
+            Authenticator::Canonicalize(second));
+}
+
 TEST(AuthenticatorTest, EmailAddressIgnoreManyUsernameDots) {
-  EXPECT_EQ(Authenticator::Canonicalize("u.ser@what.com"),
-            Authenticator::Canonicalize("Us.E.r@what.com"));
+  std::string first("u.ser@");
+  first.append(Authenticator::kSpecialCase);
+  std::string second("Us.E.r@");
+  second.append(Authenticator::kSpecialCase);
+  EXPECT_EQ(Authenticator::Canonicalize(first),
+            Authenticator::Canonicalize(second));
 }
 
 TEST(AuthenticatorTest, EmailAddressIgnoreConsecutiveUsernameDots) {
-  EXPECT_EQ(Authenticator::Canonicalize("use.r@what.com"),
-            Authenticator::Canonicalize("Us....E.r@what.com"));
+  std::string first("use.r@");
+  first.append(Authenticator::kSpecialCase);
+  std::string second("Us....E.r@");
+  second.append(Authenticator::kSpecialCase);
+  EXPECT_EQ(Authenticator::Canonicalize(first),
+            Authenticator::Canonicalize(second));
 }
 
 TEST(AuthenticatorTest, EmailAddressDifferentOnesRejected) {
   EXPECT_NE(Authenticator::Canonicalize("who@what.com"),
             Authenticator::Canonicalize("Us....E.r@what.com"));
 }
 
 TEST(AuthenticatorTest, EmailAddressIgnorePlusSuffix) {
   EXPECT_EQ(Authenticator::Canonicalize("user+cc@what.com"),
             Authenticator::Canonicalize("user@what.com"));
 }
 
 TEST(AuthenticatorTest, EmailAddressIgnoreMultiPlusSuffix) {
   EXPECT_EQ(Authenticator::Canonicalize("user+cc+bcc@what.com"),
             Authenticator::Canonicalize("user@what.com"));
 }
 
 }  // namespace chromeos