Issue 6089002: Fix failing unit test for cros_mark_as_stable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6089002: Fix failing unit test for cros_mark_as_stable. (Closed)

Created:
10 years ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Fix failing unit test for cros_mark_as_stable. Change-Id: I683cdbec489395bbce53ae4d4ba45ec3538c2aac BUG=chromium-os:8693 TEST=Run unit tests. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=892e6d8

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cros_mark_as_stable_unittest.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

10 years ago (2010-12-21 20:30:46 UTC) #2

LGTM.  Thanks for fixing this!

On Tue, Dec 21, 2010 at 11:37 AM,  <davidjames@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> Fix failing unit test for cros_mark_as_stable.
>
> Change-Id: I683cdbec489395bbce53ae4d4ba45ec3538c2aac
>
> BUG=chromium-os:8693
> TEST=Run unit tests.
>
> Please review this at http://codereview.chromium.org/6089002/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M cros_mark_as_stable_unittest.py
>
>
> Index: cros_mark_as_stable_unittest.py
> diff --git a/cros_mark_as_stable_unittest.py
> b/cros_mark_as_stable_unittest.py
> index
>
4f9763e7f947039d7892d7c61ae0fd66fce440b4..3c6d5da6cd49e7f15fe2995d7c762489f38fa716
> 100755
> --- a/cros_mark_as_stable_unittest.py
> +++ b/cros_mark_as_stable_unittest.py
> @@ -33,7 +33,7 @@ class NonClassTests(mox.MoxTestBase):
>     cros_mark_as_stable.GitBranch.Exists().AndReturn(True)
>     cros_mark_as_stable._SimpleRunCommand('git log --format=format:%s%n%n%b
> ' +
>                           self._tracking_branch + '..').AndReturn(git_log)
> -    cros_mark_as_stable._SimpleRunCommand('git remote update')
> +    cros_mark_as_stable._SimpleRunCommand('repo sync .')
>     cros_mark_as_stable._SimpleRunCommand('git merge --squash %s' %
>                                           self._branch)
>     cros_mark_as_stable._SimpleRunCommand('git commit -m "%s"' %
>
>
>

Expand Messages | Collapse Messages