Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(685)

Issue 6088014: Change site_logging to cros_logging in server side test files. (Closed)

Created:
9 years, 11 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org
Visibility:
Public.

Description

Change site_logging to cros_logging in server side test files. Change-Id: I78bc265447ed5e43b2eb06d3b3391d30704e717a BUG=7236 TEST= Seems like I mis-tested the previous changelist since site_logging.py file was originally pulled into chroot. The issue was revealed from a fresh client/chroot. Now this should work. New client --> new chroot --> emerge autotest --> run bvt. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a59e1dd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py View 2 chunks +2 lines, -2 lines 0 comments Download
M server/site_tests/suites/control.bvt View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ericli
9 years, 11 months ago (2011-01-06 22:06:45 UTC) #1
kmixter1
9 years, 11 months ago (2011-01-06 22:27:07 UTC) #2
LGTM

On Thu, Jan 6, 2011 at 2:06 PM, <ericli@chromium.org> wrote:

> Reviewers: kmixter1,
>
> Description:
> Change site_logging to cros_logging in server side test files.
>
> Change-Id: I78bc265447ed5e43b2eb06d3b3391d30704e717a
>
> BUG=7236
> TEST=
> Seems like I mis-tested the previous changelist since site_logging.py file
> was
> originally pulled into chroot.
>
> The issue was revealed from a fresh client/chroot.
>
> Now this should work.
>
> New client --> new chroot --> emerge autotest --> run bvt.
>
> Please review this at http://codereview.chromium.org/6088014/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/autotest.git@master
>
> Affected files:
>  M server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
>  M server/site_tests/suites/control.bvt
>
>
> Index:
> server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
> diff --git
> a/server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
> b/server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
> index
>
4eac61b6bf78711fc8a912baa61ed7582a3a79be..5b08437636500ebfe667d09591ceb860bbeec5b2
> 100644
> ---
> a/server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
> +++
> b/server/site_tests/logging_KernelCrashServer/logging_KernelCrashServer.py
> @@ -3,8 +3,8 @@
>  # found in the LICENSE file.
>
>  import logging, os, shutil, time
> -from autotest_lib.client.bin import site_logging
>  from autotest_lib.client.common_lib import error
> +from autotest_lib.client.cros import cros_logging
>  from autotest_lib.server import autotest, site_host_attributes, test
>
>  _CONSENT_FILE = '/home/chronos/Consent To Send Stats'
> @@ -90,7 +90,7 @@ class logging_KernelCrashServer(test.test):
>     def run_once(self, host=None):
>         # For the entire duration of this server test (across crashes
>         # and boots after crashes) we want to disable log rotation.
> -        log_pauser = site_logging.LogRotationPauser(host)
> +        log_pauser = cros_logging.LogRotationPauser(host)
>         try:
>             log_pauser.begin()
>             self._run_while_paused(host)
> Index: server/site_tests/suites/control.bvt
> diff --git a/server/site_tests/suites/control.bvt
> b/server/site_tests/suites/control.bvt
> index
>
9f00be06d354247db9bec3a462c4de0081cbd442..d2be5c9ffdcd94b9c47141dd5c734bb8cae490a2
> 100644
> --- a/server/site_tests/suites/control.bvt
> +++ b/server/site_tests/suites/control.bvt
> @@ -15,7 +15,7 @@ that a build has some minimal functionality.  These are
> meant to run quickly
>  in less than 30 minutes and should maximize coverage.
>  """
>
> -from autotest_lib.client.bin import site_logging
> +from autotest_lib.client.cros import cros_logging
>  from autotest_lib.server import site_host_attributes
>
>  TESTS = [
> @@ -57,7 +57,7 @@ def run_tests(machine):
>
>   # Disable log rotation while shutting down just in case
>   # platform_Shutdown needs to find logs.
> -  log_pauser = site_logging.LogRotationPauser(client)
> +  log_pauser = cros_logging.LogRotationPauser(client)
>   log_pauser.begin()
>   client.reboot()
>   client_at.run_test('platform_Shutdown')
>
>
>

Powered by Google App Engine
This is Rietveld 408576698