Issue 6088010: Pass a correct input method descriptor to the ActiveInputMethodsChanged function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6088010: Pass a correct input method descriptor to the ActiveInputMethodsChanged function. (Closed)

Created:
9 years, 11 months ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews, davemoore+watch_chromium.org, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Pass a correct input method descriptor to the ActiveInputMethodsChanged function. A comment explaining why ActiveInputMethodsChanged has to be called in FlushImeConfig() is also added since it took some time for me to figure out why it was necessary. BUG=chromium-os:10676 TEST=manually done. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70725

Patch Set 1 #

Patch Set 2 : added tools/cros.DEPS/DEPS, running try bots #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
	M	chrome/browser/chromeos/cros/input_method_library.cc	View	1	1 chunk	+27 lines, -4 lines	0 comments	Download
	M	tools/cros.DEPS/DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

9 years, 11 months ago (2011-01-07 06:57:02 UTC) #3

On 2011/01/07 01:52:44, satorux1 wrote:
> LGTM. Nice documentation as well.

Added tools/cros.DEPS/DEPS to pull the cros.git change.
I'll submit the change when git try returns success.

Expand Messages | Collapse Messages