Issue 6088008: Remove wstring from l10n_util. Part 7....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6088008: Remove wstring from l10n_util. Part 7.... (Closed)

Created:
9 years, 11 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Remove wstring from l10n_util. Part 7. BUG=9911 TEST=no visible changes; all tests pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70654

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+350 lines, -269 lines)			Patch
M	chrome/browser/ui/views/about_chrome_view.cc	View	4 chunks	+16 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/views/autofill_profiles_view_win.cc	View	9 chunks	+20 lines, -17 lines	0 comments	Download
MM	chrome/browser/ui/views/clear_browsing_data_view.cc	View	1 chunk	+18 lines, -17 lines	0 comments	Download
MM	chrome/browser/ui/views/clear_server_data.cc	View	3 chunks	+20 lines, -17 lines	0 comments	Download
M	chrome/browser/ui/views/collected_cookies_win.cc	View	7 chunks	+22 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/views/confirm_message_box_dialog.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/cookie_info_view.cc	View	4 chunks	+16 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/views/database_info_view.cc	View	2 chunks	+9 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/default_search_view.cc	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_bubble.cc	View	4 chunks	+23 lines, -13 lines	0 comments	Download
M	chrome/browser/ui/views/first_run_search_engine_view.cc	View	5 chunks	+10 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/generic_info_view.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/hung_renderer_view.cc	View	4 chunks	+7 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/views/importer_lock_view.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/importer_view.cc	View	3 chunks	+18 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/views/importing_progress_view.cc	View	5 chunks	+18 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/views/indexed_db_info_view.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/keyword_editor_view.cc	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/local_storage_info_view.cc	View	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/local_storage_set_item_info_view.cc	View	2 chunks	+8 lines, -7 lines	1 comment	Download
M	chrome/browser/ui/views/login_view.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/page_info_bubble_view.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/reload_button.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/repost_form_warning_view.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/shell_dialogs_win.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/ssl_client_certificate_selector_win.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	6 chunks	+29 lines, -15 lines	0 comments	Download
M	chrome/browser/ui/views/uninstall_view.cc	View	5 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/update_recommended_message_box.cc	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/url_picker.cc	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/views/user_data_dir_dialog.cc	View	5 chunks	+12 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/wrench_menu.cc	View	7 chunks	+12 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

9 years, 11 months ago (2011-01-06 19:48:28 UTC) #2

LGTM

http://codereview.chromium.org/6088008/diff/1/chrome/browser/ui/views/local_s...
File chrome/browser/ui/views/local_storage_set_item_info_view.cc (right):

http://codereview.chromium.org/6088008/diff/1/chrome/browser/ui/views/local_s...
chrome/browser/ui/views/local_storage_set_item_info_view.cc:76: //
http://crbug.com/68688
Nice catch!

Expand Messages | Collapse Messages