Issue 6088007: chromeos: Add OS credits link to about page.

Issue 6088007: chromeos: Add OS credits link to about page. (Closed)

Created:
9 years, 12 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
arv (Not doing code reviews)

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/chrome/app

Visibility:
Public.

Description

chromeos: Add OS credits link to about page. This adds an additional line of text below the Chromium open source information linking to about:os-credits, the page listing Chromium-OS-specific open source packages. BUG=chromium-os:6728 TEST=built it for chrome os and checked that the new link works. also checked that the linux version is unchanged Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70249

Patch Set 1 #

Patch Set 2 : add #if around cros-only consts #

Total comments: 3

Created: 9 years, 12 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -1 line)			Patch
M	chrome/app/chromium_strings.grd	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/options/about_page_handler.cc	View	1	3 chunks	+25 lines, -1 line	3 comments	Download
M	chrome/browser/resources/options/about_page.html	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	chrome/common/url_constants.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/url_constants.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Daniel Erat

http://codereview.chromium.org/6088007/diff/2001/chrome/browser/dom_ui/options/about_page_handler.cc File chrome/browser/dom_ui/options/about_page_handler.cc (right): http://codereview.chromium.org/6088007/diff/2001/chrome/browser/dom_ui/options/about_page_handler.cc#newcode179 chrome/browser/dom_ui/options/about_page_handler.cc:179: DCHECK(link2_end != std::wstring::npos); noticed this typo http://codereview.chromium.org/6088007/diff/2001/chrome/browser/dom_ui/options/about_page_handler.cc#newcode219 chrome/browser/dom_ui/options/about_page_handler.cc:219: WideToUTF16Hack(cros_text.substr(0, ...

9 years, 12 months ago (2010-12-29 01:11:44 UTC) #1

arv (Not doing code reviews)

9 years, 12 months ago (2010-12-29 01:26:38 UTC) #2

LGTM

http://codereview.chromium.org/6088007/diff/2001/chrome/browser/dom_ui/option...
File chrome/browser/dom_ui/options/about_page_handler.cc (right):

http://codereview.chromium.org/6088007/diff/2001/chrome/browser/dom_ui/option...
chrome/browser/dom_ui/options/about_page_handler.cc:219:
WideToUTF16Hack(cros_text.substr(0, cros_link)));
On 2010/12/29 01:11:44, Daniel Erat wrote:
> I tried to match the broken indenting of the rest of the file. :-/  Let me
know
> if I should clean everything up, at the cost of some vertical space.

Either way.

Expand Messages | Collapse Messages