Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: test/cctest/test-debug.cc

Issue 6086010: Update debugger test to expect new default break on exceptions settings. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-debug.cc
===================================================================
--- test/cctest/test-debug.cc (revision 6187)
+++ test/cctest/test-debug.cc (working copy)
@@ -3712,7 +3712,7 @@
v8::V8::AddMessageListener(MessageCallbackCount);
v8::Debug::SetDebugEventListener(DebugEventCounter);
- // Initial state should be break on uncaught exception.
+ // Initial state should be no break on exceptions.
DebugEventCounterClear();
MessageCallbackCountClear();
caught->Call(env->Global(), 0, NULL);
@@ -3720,8 +3720,8 @@
CHECK_EQ(0, uncaught_exception_hit_count);
CHECK_EQ(0, message_callback_count);
notCaught->Call(env->Global(), 0, NULL);
- CHECK_EQ(1, exception_hit_count);
- CHECK_EQ(1, uncaught_exception_hit_count);
+ CHECK_EQ(0, exception_hit_count);
+ CHECK_EQ(0, uncaught_exception_hit_count);
CHECK_EQ(1, message_callback_count);
// No break on exception
@@ -3841,6 +3841,9 @@
v8::HandleScope scope;
DebugLocalContext env;
+ // For this test, we want to break on uncaught exceptions:
+ ChangeBreakOnException(false, true);
+
v8::internal::Top::TraceException(false);
// Create a function for checking the function when hitting a break point.
@@ -3892,6 +3895,9 @@
v8::HandleScope scope;
DebugLocalContext env;
+ // For this test, we want to break on uncaught exceptions:
+ ChangeBreakOnException(false, true);
+
// Create a function for checking the function when hitting a break point.
frame_function_name = CompileFunction(&env,
frame_function_name_source,
@@ -6523,6 +6529,10 @@
TEST(ExceptionMessageWhenMessageHandlerIsReset) {
v8::HandleScope scope;
DebugLocalContext env;
+
+ // For this test, we want to break on uncaught exceptions:
+ ChangeBreakOnException(false, true);
+
exception_event_count = 0;
const char* script = "function f() {throw new Error()};";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698