Cleanup: Remove unneeded includes of chrome_switches.h.

Cleanup: Remove unneeded includes of chrome_switches.h.

BUG=none
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70978

[Lei Zhang, 2010-12-22 21:42:40]

I don't think I caused the try bot failures...

[James Hawkins, 2010-12-22 21:54:36]

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_manager.cc:44: const string16::value_type
kLabelSeparator[] = {';', ' ', '*', 0};
Remove these spaces.

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/download/dow...
File chrome/browser/download/download_uitest.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/download/dow...
chrome/browser/download/download_uitest.cc:7: #if defined(OS_WIN)
According to the style guide, platform-specific headers go at the bottom of the
include list.

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
File chrome/browser/sync/engine/syncer_thread.cc (left):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
chrome/browser/sync/engine/syncer_thread.cc:6: #include "build/build_config.h"
The file is using a define from build_config.h so it needs to be included.

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
File chrome/browser/sync/engine/syncer_thread.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
chrome/browser/sync/engine/syncer_thread.cc:7: #if defined(OS_MACOSX)
Platform-specific includes should be at the bottom.

http://codereview.chromium.org/6086003/diff/23003/chrome/renderer/webplugin_d...
File chrome/renderer/webplugin_delegate_proxy.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/renderer/webplugin_d...
chrome/renderer/webplugin_delegate_proxy.cc:520: SkDevice* device =
backing_store_canvas_->getDevice();
Please don't add unrelated changes like this to the CL.

http://codereview.chromium.org/6086003/diff/23003/chrome/test/webdriver/sessi...
File chrome/test/webdriver/session_manager.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/test/webdriver/sessi...
chrome/test/webdriver/session_manager.cc:7: #ifdef OS_POSIX
Platform-specific includes at the bottom and include build_config.h.

[Lei Zhang, 2011-01-08 01:51:36]

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/autofill/aut...
File chrome/browser/autofill/autofill_manager.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/autofill/aut...
chrome/browser/autofill/autofill_manager.cc:44: const string16::value_type
kLabelSeparator[] = {';', ' ', '*', 0};
On 2010/12/22 21:54:36, James Hawkins wrote:
> Remove these spaces.

The linter complains about them. I didn't see anything in the style guide that
prefer one over the other, so I sided with whatever makes the linter complain
less.

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/download/dow...
File chrome/browser/download/download_uitest.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/download/dow...
chrome/browser/download/download_uitest.cc:7: #if defined(OS_WIN)
On 2010/12/22 21:54:36, James Hawkins wrote:
> According to the style guide, platform-specific headers go at the bottom of
the
> include list.

Done.

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
File chrome/browser/sync/engine/syncer_thread.cc (left):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
chrome/browser/sync/engine/syncer_thread.cc:6: #include "build/build_config.h"
On 2010/12/22 21:54:36, James Hawkins wrote:
> The file is using a define from build_config.h so it needs to be included.

syncer_thread.h already uses #if define, so it's clearly included. However, just
in case that might change in the future, I retained build_config.h.

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
File chrome/browser/sync/engine/syncer_thread.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/browser/sync/engine/...
chrome/browser/sync/engine/syncer_thread.cc:7: #if defined(OS_MACOSX)
On 2010/12/22 21:54:36, James Hawkins wrote:
> Platform-specific includes should be at the bottom.

Done.

http://codereview.chromium.org/6086003/diff/23003/chrome/renderer/webplugin_d...
File chrome/renderer/webplugin_delegate_proxy.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/renderer/webplugin_d...
chrome/renderer/webplugin_delegate_proxy.cc:520: SkDevice* device =
backing_store_canvas_->getDevice();
On 2010/12/22 21:54:36, James Hawkins wrote:
> Please don't add unrelated changes like this to the CL.

Ok.

http://codereview.chromium.org/6086003/diff/23003/chrome/test/webdriver/sessi...
File chrome/test/webdriver/session_manager.cc (right):

http://codereview.chromium.org/6086003/diff/23003/chrome/test/webdriver/sessi...
chrome/test/webdriver/session_manager.cc:7: #ifdef OS_POSIX
On 2010/12/22 21:54:36, James Hawkins wrote:
> Platform-specific includes at the bottom and include build_config.h.

Done.

[James Hawkins, 2011-01-10 18:46:56]

LGTM, thanks.