Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 6085015: Order function definitions in base/ according to the header. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
Reviewers:
brettw
CC:
chromium-reviews, Paweł Hajdan Jr., pam+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Order function definitions in base/ according to the header. BUG=68682 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70975

Patch Set 1 #

Patch Set 2 : Merge correctly this time #

Patch Set 3 : lrn2merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+973 lines, -971 lines) Patch
M base/at_exit.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/crypto/rsa_private_key.cc View 1 2 3 chunks +133 lines, -133 lines 0 comments Download
M base/crypto/rsa_private_key_nss.cc View 4 chunks +68 lines, -67 lines 0 comments Download
M base/crypto/signature_creator_nss.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M base/crypto/symmetric_key_nss.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M base/debug/trace_event.cc View 3 chunks +66 lines, -66 lines 0 comments Download
M base/file_util.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M base/file_util_posix.cc View 2 chunks +20 lines, -20 lines 0 comments Download
M base/file_util_proxy.h View 3 chunks +14 lines, -14 lines 0 comments Download
M base/file_util_proxy.cc View 4 chunks +41 lines, -41 lines 0 comments Download
M base/global_descriptors_posix.h View 1 chunk +1 line, -3 lines 0 comments Download
M base/global_descriptors_posix.cc View 4 chunks +16 lines, -12 lines 0 comments Download
M base/hmac_nss.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M base/json/json_reader.h View 2 chunks +5 lines, -5 lines 0 comments Download
M base/json/json_reader.cc View 6 chunks +25 lines, -25 lines 0 comments Download
M base/logging.cc View 2 chunks +53 lines, -53 lines 0 comments Download
M base/message_loop_proxy_impl.cc View 3 chunks +28 lines, -28 lines 0 comments Download
M base/message_pump_glib.cc View 2 chunks +19 lines, -19 lines 0 comments Download
M base/message_pump_glib_x.cc View 3 chunks +54 lines, -53 lines 0 comments Download
M base/message_pump_libevent.cc View 7 chunks +76 lines, -74 lines 0 comments Download
M base/metrics/field_trial.cc View 3 chunks +15 lines, -15 lines 0 comments Download
M base/metrics/stats_table.cc View 5 chunks +127 lines, -127 lines 0 comments Download
M base/ref_counted.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M base/shared_memory_posix.cc View 3 chunks +62 lines, -63 lines 0 comments Download
M base/synchronization/waitable_event_posix.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M base/threading/simple_thread.cc View 2 chunks +16 lines, -16 lines 0 comments Download
M base/threading/thread.cc View 3 chunks +23 lines, -23 lines 0 comments Download
M base/time.h View 2 chunks +4 lines, -4 lines 0 comments Download
base/time_posix.cc View 4 chunks +37 lines, -37 lines 0 comments Download
M base/tracked_objects.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M base/vlog.h View 2 chunks +3 lines, -14 lines 0 comments Download
M base/vlog.cc View 3 chunks +21 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Elliot Glaysher
This patch just moves code around, mostly to match the header order.
9 years, 11 months ago (2011-01-10 23:51:33 UTC) #1
brettw
9 years, 11 months ago (2011-01-10 23:54:13 UTC) #2
Rubber stamp.

Powered by Google App Engine
This is Rietveld 408576698