Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 6085013: Start reordering the methods in headers in net/. (Closed)

Created:
9 years, 11 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Start reordering the methods in headers in net/. This patch also starts reordering some of the cc files to match their headers. More of both cleanups will be done in future patches. BUG=68682 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70799

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1009 lines, -1002 lines) Patch
M net/base/cert_database.h View 2 chunks +11 lines, -11 lines 0 comments Download
M net/base/gzip_header.h View 4 chunks +9 lines, -9 lines 0 comments Download
M net/base/mock_host_resolver.h View 3 chunks +12 lines, -12 lines 0 comments Download
M net/base/registry_controlled_domain.h View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/sdch_manager.cc View 8 chunks +225 lines, -224 lines 0 comments Download
M net/base/ssl_config_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/base/transport_security_state.h View 3 chunks +5 lines, -5 lines 0 comments Download
M net/base/x509_certificate.h View 2 chunks +5 lines, -5 lines 0 comments Download
M net/disk_cache/backend_impl.h View 2 chunks +18 lines, -18 lines 1 comment Download
M net/disk_cache/backend_impl.cc View 2 chunks +96 lines, -96 lines 0 comments Download
M net/disk_cache/entry_impl.h View 2 chunks +22 lines, -22 lines 0 comments Download
M net/disk_cache/entry_impl.cc View 3 chunks +393 lines, -395 lines 0 comments Download
M net/disk_cache/file.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/disk_cache/mem_backend_impl.h View 3 chunks +21 lines, -21 lines 0 comments Download
M net/disk_cache/mem_backend_impl.cc View 10 chunks +108 lines, -108 lines 0 comments Download
M net/disk_cache/rankings.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/http/http_auth_cache.h View 5 chunks +11 lines, -10 lines 0 comments Download
M net/http/http_response_headers.h View 4 chunks +23 lines, -23 lines 0 comments Download
M net/http/http_response_info.h View 2 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/proxy/proxy_service.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/socket/dns_cert_provenance_checker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.h View 2 chunks +6 lines, -6 lines 0 comments Download
M net/socket_stream/socket_stream.h View 4 chunks +7 lines, -7 lines 0 comments Download
M net/spdy/spdy_protocol.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/url_request/url_request_job_metrics.h View 2 chunks +3 lines, -3 lines 0 comments Download
M net/websockets/websocket_handshake_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_handshake_handler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/websockets/websocket_job.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
This patch is rubberstampable by a single person. It looks large and scary but it ...
9 years, 11 months ago (2011-01-07 22:04:49 UTC) #1
willchan no longer on Chromium
LGTM
9 years, 11 months ago (2011-01-07 22:14:01 UTC) #2
eroman
LGTM
9 years, 11 months ago (2011-01-07 22:18:18 UTC) #3
rvargas (doing something else)
9 years, 11 months ago (2011-01-08 00:25:57 UTC) #4
http://codereview.chromium.org/6085013/diff/1/net/disk_cache/backend_impl.h
File net/disk_cache/backend_impl.h (right):

http://codereview.chromium.org/6085013/diff/1/net/disk_cache/backend_impl.h#n...
net/disk_cache/backend_impl.h:247: // Backend interface.
Sorry to differ, but I *really* prefer the current order of these files: the
public interface is already clearly separated from implementation, and it is at
the beginning of the class, not at the end of the public section. As far as I
remember, there was not a clear decision to enforce this particular order on the
dev thread.

I know this doesn't make things easy for your plugin, but I believe the current
order is easier to follow for a human trying to understand what this code does.

Powered by Google App Engine
This is Rietveld 408576698