Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issue 6085009: Add an instance parameter to var objects, audio, and the 2D API. This replace... (Closed)

Created:
9 years, 11 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
neb
CC:
chromium-reviews, Alpha Left Google, Sergey Ulanov, dmac, darin-cc_chromium.org, awong, garykac
Visibility:
Public.

Description

Add an instance parameter to var objects, audio, and the 2D API. This replaces the module in most cases. This will be used in the proxy to multiplex one plugin across multiple renderer processes. We need the instance in the proxy to know which process to send it to. I added a deprecated var object creation function for native client, which depends on the module and this is very difficult to change. Because it doesn't have the multiplexing requirements, this is fine for now. TEST=ppapi ui tests BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70721

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -95 lines) Patch
M ppapi/c/dev/ppb_audio_config_dev.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ppapi/c/dev/ppb_var_deprecated.h View 2 chunks +10 lines, -2 lines 0 comments Download
M ppapi/c/ppb_graphics_2d.h View 4 chunks +5 lines, -6 lines 0 comments Download
M ppapi/c/ppb_image_data.h View 4 chunks +4 lines, -3 lines 0 comments Download
M ppapi/cpp/dev/audio_config_dev.h View 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/cpp/dev/audio_config_dev.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/cpp/dev/audio_dev.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/dev/audio_dev.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/cpp/graphics_2d.h View 2 chunks +2 lines, -1 line 0 comments Download
M ppapi/cpp/graphics_2d.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M ppapi/cpp/image_data.h View 2 chunks +3 lines, -1 line 0 comments Download
M ppapi/cpp/image_data.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/cpp/paint_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/var.h View 2 chunks +4 lines, -1 line 0 comments Download
M ppapi/cpp/var.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ppapi/example/example.cc View 6 chunks +10 lines, -5 lines 0 comments Download
M ppapi/tests/test_buffer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_case.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_graphics_2d.cc View 19 chunks +31 lines, -27 lines 0 comments Download
M ppapi/tests/test_image_data.cc View 5 chunks +14 lines, -11 lines 0 comments Download
M remoting/client/plugin/chromoting_instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/client/plugin/pepper_view.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_audio_impl.cc View 4 chunks +9 lines, -6 lines 0 comments Download
M webkit/plugins/ppapi/ppb_graphics_2d_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/ppb_image_data_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M webkit/plugins/ppapi/var.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years, 11 months ago (2011-01-05 23:33:40 UTC) #1
neb
9 years, 11 months ago (2011-01-06 00:35:27 UTC) #2
On 2011/01/05 23:33:40, brettw wrote:

There's a valid Lint complaint in example/example.cc, and trybots seem unhappy,
modulo that, LGTM.

Powered by Google App Engine
This is Rietveld 408576698