Issue 6085006: Reorder the functions in stub-cache-x64.cc, so they are in the same order as ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6085006: Reorder the functions in stub-cache-x64.cc, so they are in the same order as ... (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reorder the functions in stub-cache-x64.cc, so they are in the same order as in stub-cache-ia32.cc. Committed: http://code.google.com/p/v8/source/detail?r=6140

Patch Set 3 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1127 lines, -1130 lines)			Patch
	M	src/ia32/stub-cache-ia32.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/x64/stub-cache-x64.cc	View	1 2	25 chunks	+1126 lines, -1130 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

Functions have just been cut and pasted into other locations in the same file.

9 years, 11 months ago (2011-01-03 16:45:10 UTC) #1

Lasse Reichstein

LGTM. http://codereview.chromium.org/6085006/diff/1/src/x64/stub-cache-x64.cc File src/x64/stub-cache-x64.cc (left): http://codereview.chromium.org/6085006/diff/1/src/x64/stub-cache-x64.cc#oldcode1431 src/x64/stub-cache-x64.cc:1431: I actually prefer the whitespace here, between declarations ...

9 years, 11 months ago (2011-01-03 16:50:11 UTC) #2

William Hesse

9 years, 11 months ago (2011-01-04 08:50:56 UTC) #3

http://codereview.chromium.org/6085006/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (left):

http://codereview.chromium.org/6085006/diff/1/src/x64/stub-cache-x64.cc#oldco...
src/x64/stub-cache-x64.cc:1431: 
On 2011/01/03 16:50:11, Lasse Reichstein wrote:
> I actually prefer the whitespace here, between declarations and operative
code.

Actually, the functions CompileStringCharAtCall and CompileStringCharCodeAtCall
needed to be swapped, so this change was in the wrong function.  It makes it
consistent with the spacing on ia32.

Changing ia32 so that this change is not necessary.

Expand Messages | Collapse Messages

Issue 6085006: Reorder the functions in stub-cache-x64.cc, so they are in the same order as ... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages