Issue 6084010: Add partially-implemented TypeRecordingBinaryOpStub to x64 platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6084010: Add partially-implemented TypeRecordingBinaryOpStub to x64 platform. (Closed)

Created:
9 years, 11 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add partially-implemented TypeRecordingBinaryOpStub to x64 platform. Committed: http://code.google.com/p/v8/source/detail?r=6177

Patch Set 2 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+287 lines, -14 lines)			Patch
M	src/ia32/code-stubs-ia32.h	View	1	2 chunks	+0 lines, -11 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.h	View	1	2 chunks	+99 lines, -1 line	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1	1 chunk	+188 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h File src/x64/code-stubs-x64.h (right): http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h#newcode294 src/x64/code-stubs-x64.h:294: return (op_ == Token::ADD) || (op_ == Token::MUL); ...

9 years, 11 months ago (2011-01-05 11:48:46 UTC) #2

William Hesse

9 years, 11 months ago (2011-01-05 12:29:06 UTC) #3

http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h
File src/x64/code-stubs-x64.h (right):

http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h#newcod...
src/x64/code-stubs-x64.h:294: return (op_ == Token::ADD) || (op_ == Token::MUL);
On 2011/01/05 11:48:46, Lasse Reichstein wrote:
> Are bit-ops not handled by this stub?

This function is never used, and the functions GenerateCall() are declared but
never defined.  Removed on ia32 and x64.

Expand Messages | Collapse Messages

Issue 6084010: Add partially-implemented TypeRecordingBinaryOpStub to x64 platform. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages