Chromium Code Reviews

Issue 6084010: Add partially-implemented TypeRecordingBinaryOpStub to x64 platform. (Closed)

Created:
9 years, 11 months ago by William Hesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Add partially-implemented TypeRecordingBinaryOpStub to x64 platform. Committed: http://code.google.com/p/v8/source/detail?r=6177

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Stats (+287 lines, -14 lines)
M src/ia32/code-stubs-ia32.h View 2 chunks +0 lines, -11 lines 0 comments
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -1 line 0 comments
M src/x64/code-stubs-x64.h View 2 chunks +99 lines, -1 line 0 comments
M src/x64/code-stubs-x64.cc View 1 chunk +188 lines, -1 line 0 comments

Messages

Total messages: 3 (0 generated)
William Hesse
9 years, 11 months ago (2011-01-04 12:22:22 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h File src/x64/code-stubs-x64.h (right): http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h#newcode294 src/x64/code-stubs-x64.h:294: return (op_ == Token::ADD) || (op_ == Token::MUL); ...
9 years, 11 months ago (2011-01-05 11:48:46 UTC) #2
William Hesse
9 years, 11 months ago (2011-01-05 12:29:06 UTC) #3 
http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h
File src/x64/code-stubs-x64.h (right):

http://codereview.chromium.org/6084010/diff/1/src/x64/code-stubs-x64.h#newcod...
src/x64/code-stubs-x64.h:294: return (op_ == Token::ADD) || (op_ == Token::MUL);
On 2011/01/05 11:48:46, Lasse Reichstein wrote:
> Are bit-ops not handled by this stub?

This function is never used, and the functions GenerateCall() are declared but
never defined.  Removed on ia32 and x64.

Powered by Google App Engine