Issue 6083001: Refactoring out object printing functions into objects-printer.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6083001: Refactoring out object printing functions into objects-printer.cc. (Closed)

Created:
10 years ago by marklam

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Refactoring out object printing functions into objects-printer.cc. Committed: http://code.google.com/p/v8/source/detail?r=6110

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+784 lines, -847 lines)			Patch
M	src/SConscript	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/objects-debug.cc	View		23 chunks	+2 lines, -845 lines	0 comments	Download
A	src/objects-printer.cc	View		1 chunk	+778 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

marklam

Refactored object printing functions into objects-printer.cc. The review error check says there are 10 errors ...

10 years ago (2010-12-20 21:03:30 UTC) #1

Søren Thygesen Gjesse

10 years ago (2010-12-22 13:09:14 UTC) #2

On 2010/12/20 21:03:30, marklam wrote:
> Refactored object printing functions into objects-printer.cc.
> 
> The review error check says there are 10 errors in objects-printer.cc, but
> looking at the file, I see that it is identical to objects-debug.cc as far as
> the reported issues are concerned.  I assume that the errors can be ignored.
> 
> I updated v8.gyp as well, but don't know how to update the xcode and visual
> studio projects.  Can you please update those as well?  Thanks.

Committed in r6110.

Thank you for the patch.

Closing issue.

Expand Messages | Collapse Messages